Don't trigger invirt-reload multiple times
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Invirt Project |
Fix Released
|
Undecided
|
Unassigned | ||
XVM |
Fix Committed
|
Undecided
|
Unassigned |
Bug Description
Currently we use triggers as they're "intended" to be used to cause an xvm-prodconfig or xvm-devconfig update to trigger running invirt-reload. But since triggers aren't guaranteed to only run once over the course of the install, ours run twice (I don't remember exactly when).
We should instead use the "legacy compatibility" triggering mechanism that most other packages are currently using. For this mechanism, the package activating the trigger doesn't do so through dpkg directly. Instead, it just runs the script (i.e. invirt-reload). If the script is called from a maintainer script, it schedules the trigger itself.
For an example of this, see /sbin/ldconfig or /usr/sbin/
Originally fixed in r2941, with a followup fix to make it actually work in r2966.
Combined with changes to all the relevant config packages in r2940.
This code has been deployed to XVM dev, and will probably go to prod in a few days.