Comment 17 for bug 583124

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

After reading the full patch and thinking about this for a while, I've come to a conclusion on this.

This is a refactoring made purely to avoid the dependency on gdk, which is a library to interact with X.

To avoid the gdk library, though, we're adding a dependency on three new modules: python-xlib, autox.py, and pyxlib_ctypes, and are embedding 8 thousand lines of code to avoid the issue that some of these dependencies are not pre-packaged in most distributions.

With this rationale, i don't think it makes much sense to integrate these changes from a maintenance and usage perspective. There's no actual benefit for the library user, and replacing three calls to a single X library by several calls to multiple libraries and embedding some of them in the code will increase maintenance cost which I don't want to have.