wrong notes size at startup

[hunt]

at startup, xpad reopen all notes with wrong windows size.
I noticed the following error:

** (xpad:3860181): WARNING **: 18:09:46.469: There is a problem in the program Xpad. In function 'xpad_pad_toolbar_size_allocate' the variable 'event->height' is not a positive number. Please send a bugreport to https://bugs.launchpad.net/xpad/+filebug to help improve Xpad.

cheers

[Arthur Borsboom (arthurborsboom)]

Hi Hunt,

Which Xpad version are you using?
Would you mind describing how to reproduce the 'wrong notes size at startup' issue?

[Emmanuel (ubuntu-oi)]

Hi,
With the last version (from git master)
starting xpad make all existing pads diplayed with the minimal size.
It was tested on Debian Bookworm with xfce
but version 5.7.0 (which is in Debian repo) is working fine for size
regards,

[Arthur Borsboom (arthurborsboom)]

Right now, the default size of new pads is 300x300 pixels.

If I create a new pad and enlarge it by dragging a window corner and quit Xpad (CTRL-Q), then the size is restored of the pads as it was before quitting.

I might misunderstand the problem.

Would you mind to provide more details preferable by a way to reproduce the issue?

[Emmanuel (ubuntu-oi)]

Hi,
I've dig in
i finally found what's wrong

Go to Preferences--> View
- unselect all
- select "Show toolbar"
- select "Show scrollbar"
- select "Show window decorations"

Create a pad
Change its size
quit xpad
launch xpad
xpad size is reset to default (which is wrong)

It's seams to be related to the deactivation of "Autohide toolbar"
Regards

[Arthur Borsboom (arthurborsboom)]

Good find.

Indeed, it seems that disabling Autohide toolbar reset the pads sizes to default.
I have been able to reproduce it.

I will dive into the code.

[Arthur Borsboom (arthurborsboom)]

I have found a piece of code that was preventing the resizing of the pads on load when the toolbar was enabled and not auto hiding. I have removed this code and to me it seems to restore the sizing without breaking the toolbar functionality.

I have pushed the changes to the master branch.

Would you mind to have a look?

[Emmanuel (ubuntu-oi)]

Hi,
It works great for me.

however i'm not the user who send the issue so i don't know if it really solve his problem
but i think you can close this one
Would be nice to create a version for ubuntu and debian. (I don't know how to do this)

I'm done with all my issues.
Do you need help on others issues ?

[Arthur Borsboom (arthurborsboom)]

> It works great for me.

Thanks for helping.

> i think you can close this one

I will close the bug report if a new Xpad version has been released.

> Do you need help on others issues ?

I am glad you ask! :-)

I have been neglecting the bug reports of Xpad for quite some time.
Recently I noticed that there are about 70 open bug reports.

They need to be looked.

Some are actual bugs but need a way to reproduce it.
Some are usability issues and need help by asking the right questions.
Some are feature requests that are nice to be implmented.
Some are feature requests that are too hard to implement, undesirable, etc.
Some are bug reports that have already been fixed.

If you are motivated to help out by sorting, cleaning, asking questions and prioritizing them, then that would be appreciated.

And you can always join coding all based on your motivation, availability, and preference.
Remember it should be fun to do; it is a hobby, not work. :-)

[Emmanuel (ubuntu-oi)]

I would be glade to help.
I don't know if i can help with coding. I found the app a little bit complicated (UI is not within my skill)
My coding skill is mainly for things with strong real time constraints.
But nowdays, I'm not coding anymore. So it's ok to do it at home.

I'll take a look at the other issues
If you don't mind, i think it would be fine to have a stable version before looking for improvement.

So i'll try to look at bugs first and try to reproduce them or ask questions about...
I'll do it next year.

Merry Christmas

[Emmanuel (ubuntu-oi)]

Arthur,
I try to add Tag in order to classify issues but it's not accepted.
Is there a particular way to do int ?
Did i need more rights ?