Refactor the whole code and also Follow GLib/GTK+ best practices for the order of #include's

[Sagar Ghuge]

See https://wiki.gnome.org/Projects/GTK%2B/BestPractices/GlibIncludes

The most important thing is to first include the corresponding header in a .c
file.

And also No need of function prototype if declaration and callback sequence is maintained neatly.

Will result into less number lines of code.

[Ankita Patil (patil-ankita-r)]

Hi,

I have created a patch upon sagar's changes.

This patch contains the changes which are related to fixing the indentation and spacing in source code.

[Sagar Ghuge (ghugesss)]

Thanks for patch Ankita. Looks good to me.

[Arthur Borsboom (arthurborsboom)]

Hi Ankita,

Your patch looks good and is easy to read.
Thanks for doing it this way.

I have tested Xpad and it looks like the important parts are still working.
Detailed testing will be done before the release of v4.4

The patch has been merged into the main branch.

Thanks for your work to clean up the code.

Cheers,
Arthur.

[Sagar Ghuge (ghugesss)]

Hi Arthur,

You forgot to merge the my branch. It includes the head guards and order of includes changes.

[Arthur Borsboom (arthurborsboom)]

Shoot, I have forgotten your branch.
I will merge it into Xpad 4.5, since v4.4 is already released.
Only ugly bugs will be fixed in v4.4.1

I will reopen the bug report, so we won't forget it.

Cheers,
Arthur.

[Arthur Borsboom (arthurborsboom)]

Hi Sagar,

Can you propose your branch for merging?