Refactor the whole code and also Follow GLib/GTK+ best practices for the order of #include's

Bug #1366510 reported by Sagar Ghuge on 2014-09-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xpad
Wishlist
Sagar Ghuge

Bug Description

See https://wiki.gnome.org/Projects/GTK%2B/BestPractices/GlibIncludes

The most important thing is to first include the corresponding header in a .c
file.

And also No need of function prototype if declaration and callback sequence is maintained neatly.

Will result into less number lines of code.

Related branches

Changed in xpad:
importance: Undecided → Wishlist
assignee: nobody → Sagar Ghuge (ghugesss)
milestone: none → 4.4
status: New → In Progress
Ankita Patil (patil-ankita-r) wrote :

Hi,

I have created a patch upon sagar's changes.

This patch contains the changes which are related to fixing the indentation and spacing in source code.

Ankita Patil (patil-ankita-r) wrote :
Sagar Ghuge (ghugesss) wrote :

Thanks for patch Ankita. Looks good to me.

Hi Ankita,

Your patch looks good and is easy to read.
Thanks for doing it this way.

I have tested Xpad and it looks like the important parts are still working.
Detailed testing will be done before the release of v4.4

The patch has been merged into the main branch.

Thanks for your work to clean up the code.

Cheers,
Arthur.

Changed in xpad:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Changed in xpad:
status: In Progress → Fix Committed
Changed in xpad:
status: Fix Committed → Fix Released
Sagar Ghuge (ghugesss) wrote :

Hi Arthur,

You forgot to merge the my branch. It includes the head guards and order of includes changes.

Shoot, I have forgotten your branch.
I will merge it into Xpad 4.5, since v4.4 is already released.
Only ugly bugs will be fixed in v4.4.1

I will reopen the bug report, so we won't forget it.

Cheers,
Arthur.

Changed in xpad:
status: Fix Released → In Progress
milestone: 4.4 → 4.5

Hi Sagar,

Can you propose your branch for merging?

Changed in xpad:
status: In Progress → Fix Committed
Changed in xpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers