Can't find signal function address

Bug #1332971 reported by Yuan Song
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xpad
Fix Released
Medium
jaya tiwari

Bug Description

The error happens when launch xpad with -f option. It is because, in xpad_app_init, xpad_periodic_set_callback is called before process_remote_args. Once I move xpad_periodic_init and xpad_periodic_set_callback to be before process_remote_args, the error is gone.

Related branches

Revision history for this message
Yuan Song (ysong) wrote :

But after I move xpad_periodic_set_callback and xpad_periodic_init, xpad can get stuck in an infinite loop in xpad_pad_group_destroy_pads when it calls g_slist_foreach when I close the last window. The error says "Gtk-CRITICAL **: gtk_widget_destroy: assertion 'GTK_IS_WIDGET (widget)' failed"

Revision history for this message
Arthur Borsboom (arthurborsboom) wrote :

The -f argument is not working for me at all in version 4.2 and 4.3.

I get the error: Could not read file test.txt.

Will fix in v4.4.

Thanks for reporting!

Changed in xpad:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 4.4
Revision history for this message
Arthur Borsboom (arthurborsboom) wrote :

BTW, what version are you using?

Revision history for this message
Yuan Song (ysong) wrote : Re: [Bug 1332971] Re: Can't find signal function address

I used version 4.3

On Sunday, June 22, 2014 4:40 PM, Arthur Borsboom <email address hidden> wrote:

The -f argument is not working for me at all in version 4.2 and 4.3.

I get the error: Could not read file test.txt.

Will fix in v4.4.

Thanks for reporting!

** Changed in: xpad
       Status: New => Confirmed

** Changed in: xpad
   Importance: Undecided => Medium

** Changed in: xpad
    Milestone: None => 4.4

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1332971

Title:
  Can't find signal function address

Status in Xpad:
  Confirmed

Bug description:
  The error happens when launch xpad with -f option.    It is because,
  in xpad_app_init,  xpad_periodic_set_callback is called before
  process_remote_args.  Once I move xpad_periodic_init and
  xpad_periodic_set_callback to be before process_remote_args, the error
  is gone.

To manage notifications about this bug go to:
https://bugs.launchpad.net/xpad/+bug/1332971/+subscriptions

Revision history for this message
jaya tiwari (tiwari-jaya18) wrote :

Hi,

Got a chance to debug a bit and found out that xpptr was not initailized, neither was its call back set inside xpad_periodic_signal. So added init and set_callback in xpad_pad_new_from_file.

Also, user always needs to provide the absolute path for the file, else, it takes config path if only we provide the name of file.
Is this expected or the handling of filename should be done if it is in the current working directory.

I am new to this, so please correct me wherever wrong.

Revision history for this message
Arthur Borsboom (arthurborsboom) wrote :

Hi Jaya,

Awesome that you are helping out.
Soon I will test the patch and if it seems correct, I will add it to the main branch, for the upcoming release.

For now, thanks for the effort and I will recontact you soon.

Cheers,
Arthur.

Revision history for this message
Sagar Ghuge (ghugesss) wrote :

Code seems ok. Didn't tried out. I appreciate with the second part of
comment about the filename.
Hi Jaya,

Awesome that you are helping out.
Soon I will test the patch and if it seems correct, I will add it to the
main branch, for the upcoming release.

For now, thanks for the effort and I will recontact you soon.

Cheers,
Arthur.

--
You received this bug notification because you are subscribed to Xpad.
Matching subscriptions: Sagar Ghuge
https://bugs.launchpad.net/bugs/1332971

Title:
  Can't find signal function address

Status in Xpad:
  Confirmed

Bug description:
  The error happens when launch xpad with -f option. It is because,
  in xpad_app_init, xpad_periodic_set_callback is called before
  process_remote_args. Once I move xpad_periodic_init and
  xpad_periodic_set_callback to be before process_remote_args, the error
  is gone.

To manage notifications about this bug go to:
https://bugs.launchpad.net/xpad/+bug/1332971/+subscriptions

Revision history for this message
Arthur Borsboom (arthurborsboom) wrote :

The patch seems to solve the issue.
I am not sure about any side effects, but will test this before releasing v4.4

I will add the patch to the main branch.

Thanks Jaya, for the helpful work!

Changed in xpad:
status: Confirmed → Fix Committed
Revision history for this message
Sagar Ghuge (ghugesss) wrote :

Hi Arthur

It would be nice if you modify the Changelog file. Bug is solved by Jaya not by the Youn Song.

I think Jaya made a slight mistake while adding details to Changelog file.

Changed in xpad:
assignee: nobody → jaya (tiwari-jaya18)
Revision history for this message
Arthur Borsboom (arthurborsboom) wrote :

The mistake is mine. My appologies.
In my hurry, I did a wrong copy and paste.

I will fix the credits this week in the Changelog.

Revision history for this message
Arthur Borsboom (arthurborsboom) wrote :

Changelog updated with Jaya Tiwari as solver of the issue.

Changed in xpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.