Only timing mode list in EDID supported on continuous freq monitors

[AaronMa]

[Impact]
Some new laptop display set EDID continuous freq bit 1.
Then Xorg only uses the timing modes defined in EDID, no other modes are shown on Xorg.

Upstream Bug:
https://gitlab.freedesktop.org/drm/intel/-/issues/313

Fix of Xorg in merge request:
https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/421

https://cgit.freedesktop.org/xorg/xserver/commit/?id=6a79a737e2c0bc730ee693b4ea4a1530c108be4e

this is required to support new laptop models which use such panels

[Test case]
Test that a proper list of modes is shown with a panel that uses the new EDID.

[Regression potential]
The patch retains the previous code path for setting modes on GTF-able monitors, and only adds support for non-GTF monitors. So in that sense there shouldn't be any regression potential, this has been reviewed by an upstream expert.

[Rex Tsai (chihchun)]

Hi, Aaaron

It seems with the patch (https://lists.x.org/archives/xorg-devel/2020-April/058557.html) modesetting still could be failed to add additional modes if Display Range Limits Descriptor is broken. - https://bugs.launchpad.net/somerville/+bug/1875867/comments/5

[AaronMa (mapengyu)]

@Rex

Yes,
if GTF modes are defined in "Display Range Limits Descriptor ", vendors should put all modes in EDID.
That's a bug from vendors EDID.

[Robie Basak (racb)]

Please provide:

1. An explanation of the bug on users and justification for backporting the fix to the stable release.

2. A discussion of how regressions are most likely to manifest, or may manifest even if it is unlikely, as a result of this change.

3. The version in which this bug is fixed in Groovy, and please fix the status of that task.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xorg-server - 2:1.20.8-2ubuntu4

---------------
xorg-server (2:1.20.8-2ubuntu4) groovy; urgency=medium

  * xfree86-add-drm-modes-on-non-GTF-panels.patch: Add GTF modes on
    continuous-frequency monitors. (LP: #1883497)

 -- Timo Aaltonen <email address hidden> Wed, 24 Jun 2020 08:50:33 +0300

[Łukasz Zemczak (sil2100)]

Hello AaronMa, or anyone else affected,

Accepted xorg-server into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server/2:1.20.8-2ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted xorg-server (2:1.20.8-2ubuntu2.2) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

kdbusaddons/5.68.0-0ubuntu1 (armhf)
cogl/unknown (armhf)
jsunit/0.2.2-2 (arm64)
bambam/1.0.1+dfsg-1 (armhf)
aptdaemon/1.1.1+bzr982-0ubuntu32.1 (armhf)
gscan2pdf/2.6.4-1 (armhf)
gegl/0.4.22-3 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#xorg-server

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Timo Aaltonen (tjaalton)]

autopkgtests cleared

[Łukasz Zemczak (sil2100)]

Hello AaronMa, or anyone else affected,

Accepted xorg-server-hwe-18.04 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server-hwe-18.04/2:1.20.8-2ubuntu2.2~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted xorg-server-hwe-18.04 (2:1.20.8-2ubuntu2.2~18.04.1) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

nvidia-graphics-drivers-390/390.138-0ubuntu0.18.04.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#xorg-server-hwe-18.04

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Shengyao Xue (xueshengyao)]

I tested the new packages in focal-proposed on a ThinkPad P15s, which only have one resolution before. and the new packages in focal-proposed works. The details:

0. the resolution supported, only one: 1920x1080
1. the original packages:

xserver-common 2:1.20.8-2ubuntu2
xserver-xephyr 2:1.20.8-2ubuntu2
xserver-xorg-core 2:1.20.8-2ubuntu2
xserver-xorg-legacy 2:1.20.8-2ubuntu2
xwayland 2:1.20.8-2ubuntu2

2. open focal-proposed channel and "sudo apt update".

3. sudo apt install xserver-common xserver-xephyr xserver-xorg-core xserver-xorg-legacy xwayland

4. reboot

5. the new packages installed:

xserver-common 2:1.20.8-2ubuntu2.2
xserver-xephyr 2:1.20.8-2ubuntu2.2
xserver-xorg-core 2:1.20.8-2ubuntu2.2
xserver-xorg-legacy 2:1.20.8-2ubuntu2.2
xwayland 2:1.20.8-2ubuntu2.2

6. check the resolutions supported now: 1920x1080, 1680x1050, 1600x1024, 1400x1050....., total 23 resolutions supported now.

[Timo Aaltonen (tjaalton)]

Thanks, could you verify on bionic too?

[Gabriel Zhi Chen (gabrielzchen)]

I have verified on Bionic.

I tested the new packages in bionic-propoesed on ThinkPad L15, which only have one resolution before. And the new packages in focal-proposed works. The details:

0. the resolution supported, only one: 1920x1080

1. open bionic-proposed channel and 'sudo apt update'.

2. sudo apt-get install xserver-xorg-core-hwe-18.04 xserver-xorg-dev-hwe-18.04 xserver-xorg-hwe-18.04 xserver-xorg-input-all-hwe-18.04 xserver-xorg-input-evdev-dev-hwe-18.04 xserver-xorg-input-evdev-hwe-18.04 xserver-xorg-input-evdev-hwe-18.04-dbg xserver-xorg-input-joystick-dev-hwe-18.04 xserver-xorg-input-joystick-hwe-18.04 xserver-xorg-input-libinput-dev-hwe-18.04 xserver-xorg-input-libinput-hwe-18.04 xserver-xorg-input-synaptics-dev-hwe-18.04 xserver-xorg-input-synaptics-hwe-18.04 xserver-xorg-input-wacom-hwe-18.04 xserver-xorg-legacy-hwe-18.04 xserver-xorg-video-all-hwe-18.04 xserver-xorg-video-amdgpu-hwe-18.04 xserver-xorg-video-ati-hwe-18.04 xserver-xorg-video-dummy-hwe-18.04 xserver-xorg-video-fbdev-hwe-18.04 xserver-xorg-video-intel-hwe-18.04 xserver-xorg-video-intel-hwe-18.04-dbg xserver-xorg-video-nouveau-hwe-18.04 xserver-xorg-video-qxl-hwe-18.04 xserver-xorg-video-radeon-hwe-18.04 xserver-xorg-video-vesa-hwe-18.04 xserver-xorg-video-vmware-hwe-18.04

3. reboot

4. the new package installed:

ii xorg-server-source-hwe-18.04 2:1.20.8-2ubuntu2.2~18.04.1
ii xserver-xorg-core-hwe-18.04 2:1.20.8-2ubuntu2.2~18.04.1
ii xserver-xorg-dev-hwe-18.04 2:1.20.8-2ubuntu2.2~18.04.1
ii xserver-xorg-hwe-18.04 1:7.7+19ubuntu8~18.04.3
ii xserver-xorg-input-all-hwe-18.04 1:7.7+19ubuntu8~18.04.3
ii xserver-xorg-input-evdev-dev-hwe-18.04 1:2.10.6-1~18.04.1
ii xserver-xorg-input-evdev-hwe-18.04 1:2.10.6-1~18.04.1
ii xserver-xorg-input-evdev-hwe-18.04-dbg 1:2.10.6-1~18.04.1
ii xserver-xorg-input-joystick-dev-hwe-18.04 1:1.6.3-1build1~18.04.1
ii xserver-xorg-input-joystick-hwe-18.04 1:1.6.3-1build1~18.04.1
ii xserver-xorg-input-libinput-dev-hwe-18.04 0.28.1-1~18.04.1
ii xserver-xorg-input-libinput-hwe-18.04 0.28.1-1~18.04.1
ii xserver-xorg-input-synaptics-dev-hwe-18.04 1.9.1-1ubuntu1~18.04.1
ii xserver-xorg-input-synaptics-hwe-18.04 1.9.1-1ubuntu1~18.04.1
ii xserver-xorg-input-wacom-hwe-18.04 1:0.36.1-0ubuntu1~18.04.1
ii xserver-xorg-legacy-hwe-18.04 2:1.20.8-2ubuntu2.2~18.04.1
ii xserver-xorg-video-all-hwe-18.04 1:7.7+19ubuntu8~18.04.3
ii xserver-xorg-video-amdgpu-hwe-18.04 19.1.0-1~18.04.1
ii xserver-xorg-video-ati-hwe-18.04 1:19.1.0-1~18.04.1
ii xserver-xorg-video-dummy-hwe-18.04 1:0.3.8-1build3~18.04.1
ii xserver-xorg-video-fbdev-hwe-18.04 1:0.5.0-1ubuntu1~18.04.1
ii xserver-xorg-video-intel-hwe-18.04 2:2.99.917+git20171229-1ubuntu1~18.04.1
ii xserver-xorg-video-intel-hwe-18.04-dbg 2:2.99.917+git20171229-1ubuntu1~18.04.1
ii xserver-xorg-video-nouveau-h...

[AaronMa (mapengyu)]

Verified on stock Ubuntu 18.04.4
apt install xserver-xorg-core-hwe-18.04 (2:1.20.8-2ubuntu2.2~18.04.1)

Multiple resolutions can be set then.

[Łukasz Zemczak (sil2100)]

Excellent, thanks for the verification!

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for xorg-server has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xorg-server - 2:1.20.8-2ubuntu2.2

---------------
xorg-server (2:1.20.8-2ubuntu2.2) focal; urgency=medium

  * xfree86-add-drm-modes-on-non-GTF-panels.patch: Add GTF modes on
    continuous-frequency monitors. (LP: #1883497)

 -- Timo Aaltonen <email address hidden> Wed, 24 Jun 2020 09:00:21 +0300

[Launchpad Janitor (janitor)]

This bug was fixed in the package xorg-server-hwe-18.04 - 2:1.20.8-2ubuntu2.2~18.04.1

---------------
xorg-server-hwe-18.04 (2:1.20.8-2ubuntu2.2~18.04.1) bionic; urgency=medium

  * Backport to 18.04. (LP: #1883497)

 -- Timo Aaltonen <email address hidden> Fri, 03 Jul 2020 10:00:25 +0300

[Chris Halse Rogers (raof)]

Hello AaronMa, or anyone else affected,

Accepted xorg-server into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server/2:1.19.6-1ubuntu4.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted xorg-server (2:1.19.6-1ubuntu4.7) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

kio/5.44.0-0ubuntu1 (amd64, i386)
ubiquity/unknown (armhf)
kdepim-runtime/4:17.12.3-0ubuntu2 (armhf)
skimage/unknown (arm64)
kdeconnect/unknown (armhf)
aptdaemon/1.1.1+bzr982-0ubuntu19.3 (i386, armhf)
tracker/unknown (armhf)
glib2.0/2.56.4-0ubuntu0.18.04.6 (armhf)
qbzr/0.23.2-3 (i386)
kwindowsystem/5.44.0-0ubuntu1 (armhf)
coyote/unknown (arm64)
kservice/5.44.0-0ubuntu1 (s390x)
kde4libs/4:4.14.38-0ubuntu3.1 (amd64, i386)
kpimtextedit/17.12.3-0ubuntu1 (i386)
y-u-no-validate/unknown (armhf)
sphinx/unknown (armhf)
kdbusaddons/5.44.0-0ubuntu1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#xorg-server

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Timo Aaltonen (tjaalton)]

the patch has been in bionic-proposed for over three weeks, please test it

[Timo Aaltonen (tjaalton)]

regarding the remaining autopkgtest regressions:

kio/5.44.0-0ubuntu1 (amd64, i386)
kde4libs/4:4.14.38-0ubuntu3.1 (amd64, i386)

they are caused by a bad test which is now fixed upstream because it involves a harcoded date:
https://invent.kde.org/frameworks/kio/-/commit/642681ecd62e3e7cfecf6c20995c96ecc413d838

so the tests were run three days too late..

[AaronMa (mapengyu)]

Updated to xserver-xorg-core:amd64 (2:1.19.6-1ubuntu4.6, 2:1.19.6-1ubuntu4.7)

Stock Bionic got multiple resolutions to set.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xorg-server - 2:1.19.6-1ubuntu4.7

---------------
xorg-server (2:1.19.6-1ubuntu4.7) bionic; urgency=medium

  * xfree86-add-drm-modes-on-non-GTF-panels.patch: Add GTF modes on
    continuous-frequency monitors. (LP: #1883497)

 -- Timo Aaltonen <email address hidden> Tue, 15 Sep 2020 08:52:10 +0300

[Timo Aaltonen (tjaalton)]

This commit caused a regression to some user upstream, and we have a fix in hirsute but it needs to be applied to groovy as well. As there are no known bugs filed on LP about the regression, we don't have a way to reproduce the issue so the test case here is to just verify the original use case still works.

Focal has the fix already because there was a mid-air collision upload of xorg-server to groovy, resulting in my local groovy branch missing the CVE fixes from 2:1.20.9-2ubuntu1.1 that got in the archive. I rejected my groovy upload because it had the wrong buglink, but then for some reason didn't reupload a fixed and rebased version. The focal backport was eventually based on my local -2u1.1 instead of what was in groovy.

[Brian Murray (brian-murray)]

Hello AaronMa, or anyone else affected,

Accepted xorg-server into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server/2:1.20.9-2ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted xorg-server (2:1.20.9-2ubuntu1.2) for groovy have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-release-upgrader/1:20.10.14 (arm64)
bambam/1.0.2+dfsg-2 (arm64, s390x)
pandas/1.0.5+dfsg-3 (ppc64el, arm64, armhf, s390x, amd64)
software-properties/0.99.3 (ppc64el, armhf)
apport/2.20.11-0ubuntu50.3 (amd64)
glib-networking/unknown (armhf)
linssid/unknown (armhf)
aptdaemon/1.1.1+bzr982-0ubuntu34.1 (armhf, amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/groovy/update_excuses.html#xorg-server

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Brian Murray (brian-murray)]

The Groovy Gorilla has reached end of life, so this bug will not be fixed for that release