Can't change font for keyboard layout indicator

[Sergey L]

Binary package hint: xfce4-xkb-plugin

For example my system font is "Ubuntu"
But, xfce4-xkb-plugin icon (as text) font hardcoded to "Monospace Bold".

file: panel-plugin/xkb-cairo.c
#define XKB_PREFERRED_FONT "Courier New, Courier 10 Pitch, Monospace Bold %d"

1) The release of Ubuntu you are using
Ubuntu 10.10

2) The version of the package you are using
xfce4-xkb-plugin 0.5.3.3-3ubuntu2

3) What you expected to happen
Global system font for keyboard layout icon

4) What happened instead
Monospace Bold font for keyboard layout icon

[Ivan Frederiks (idfred)]

A solution based on http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=576072#15 and code of xfce xfce4-datetime-plugin.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "font_selection.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Lionel Le Folgoc (mrpouit)]

Created attachment 4187
Patch proposed by Ivan Frederiks

Hi,

An xubuntu user reported that the font used by the plugin is harcoded, and that it'd be nice to be able to set it from the settings dialog. I attached the patch he proposed (it seems to apply fine against git master).

Thanks.

[Jackson Doak (noskcaj)]

Could you please re-make the patch for the latest version? If you get it done this week, it should be ready for saucy

[Ivan Frederiks (idfred)]

Hm... I'll try to find some time for this.
Do you mean this week including weekend?
Latest version is 0.5.4.3?

[Jackson Doak (noskcaj)]

Because it's a bugfix it can probably go in any time this month, but
sooner is better

On Tue, Sep 17, 2013 at 10:52 PM, Ivan Frederiks
<email address hidden> wrote:
> Hm... I'll try to find some time for this.
> Do you mean this week including weekend?
> Latest version is 0.5.4.3?
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/733563
>
> Title:
> Can't change font for keyboard layout indicator
>
> Status in xfce4-xkb-plugin:
> Unknown
> Status in “xfce4-xkb-plugin” package in Ubuntu:
> Confirmed
> Status in “xfce4-xkb-plugin” package in Debian:
> Confirmed
>
> Bug description:
> Binary package hint: xfce4-xkb-plugin
>
> For example my system font is "Ubuntu"
> But, xfce4-xkb-plugin icon (as text) font hardcoded to "Monospace Bold".
>
> file: panel-plugin/xkb-cairo.c
> #define XKB_PREFERRED_FONT "Courier New, Courier 10 Pitch, Monospace Bold %d"
>
> 1) The release of Ubuntu you are using
> Ubuntu 10.10
>
>
> 2) The version of the package you are using
> xfce4-xkb-plugin 0.5.3.3-3ubuntu2
>
> 3) What you expected to happen
> Global system font for keyboard layout icon
>
> 4) What happened instead
> Monospace Bold font for keyboard layout icon
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/xkb/+bug/733563/+subscriptions

[Ivan Frederiks (idfred)]

Uploading updated patch.
There is an important TODO: one should update localization files.

[Timo Jyrinki (timo-jyrinki)]

A fix would be testable with:

sudo apt-add-repository ppa:timo-jyrinki/ppa
sudo apt-get update
sudo apt-get install xfce4-xkb-plugin

Testing welcome!

[Timo Jyrinki (timo-jyrinki)]

(for users with Ubuntu 14.04)

[Timo Jyrinki (timo-jyrinki)]

This would actually need FFe for 14.04 if wanted in, since it's adding a feature. So maybe more suited for uploading for u series.

[Dmitry Shachnev (mitya57)]

Right, this needs an FFe first, and probably it's too late for this cycle. Unsubscribing sponsors for now.

[Steve Dodier-Lazaro (sidi)]

<Design SIG hat on>I would actually like to see a patch that simply uses the system font, and dumps any internal reference to a font. Having plugins use a custom font for such an unimportant thing causes usability issues since users who do need a high contrast font must search through multiple UIs to fix the fonts.

The Whiskermenu and Clock plugins can be used as examples. They both use the system font.</Design SIG hat off>

[Launchpad Janitor (janitor)]

This bug was fixed in the package xfce4-xkb-plugin - 1:0.7.1-2

---------------
xfce4-xkb-plugin (1:0.7.1-2) unstable; urgency=medium

  * Upload to unstable.

 -- Yves-Alexis Perez <email address hidden> Wed, 06 May 2015 23:12:22 +0200

[Pavel Podkorytov (tierpod)]

Patch does not work correctly. Font size not changed (on a screenshot - Monospace 10 and Monospace 16).

[joshas (joshas)]

Still an issue in Xubuntu 15.10 https://bugs.launchpad.net/ubuntu/+source/xfce4-xkb-plugin/+bug/1510280
Could someone revert or fix font selection patch?