Accept button does not have focus when adding from library

[Alex Harrington]

Hello,

In 1.0.x it was possible (as reported to me by other user, never checked it myself) to accept media selection from library by pressing Enter key (when assigning to region) after selecting some checkboxes. Focus on Accept key wasn't nessessary. It's no longer works in 1.2rc.
Is it possible to restore that behavior in 1.2? Small wish if possible :)

Thanks.

[Alex Harrington (alexharrington)]

Needs investigation as to how this actually behaved in 1.x

[Alex Harrington (alexharrington)]

In 1.0.6, the "Assign" button is an <input type="submit"> style button.

In 1.2.0-rc1 the "Assign" button uses the new framework for adding buttons to forms so it's rendered as <button> tag - which then doesn't pick up the return key.

Given that you have to mouse up and down the list and mouse click each item you want to add, I'm not sure really why this is a massive problem - but I can see that being able to specify the button that gets pressed on return key might be useful elsewhere too, so perhaps look and see if that can get built in to the framework?

[Dan Garner (dangarner)]

After some investigation it appears that this does still work in Chrome (perhaps someone could confirm in Firefox?)

Adding a visible submit input element makes it work in IE also - however the moment you hide the input element with CSS (because it looks out of place) it stops working.

An alternative is to bind to the enter key event and submit the form that way, however that would play havoc with multi line edit boxes such as the text editors.

I am not sure how to proceed.... suggestions welcome....

[Alex Harrington (alexharrington)]

It doesn't work in Firefox

On 22 Jul 2010 20:35, "Dan Garner" <email address hidden> wrote:
> After some investigation it appears that this does still work in Chrome
> (perhaps someone could confirm in Firefox?)
>
> Adding a visible submit input element makes it work in IE also - however
> the moment you hide the input element with CSS (because it looks out of
> place) it stops working.
>
> An alternative is to bind to the enter key event and submit the form
> that way, however that would play havoc with multi line edit boxes such
> as the text editors.
>
> I am not sure how to proceed.... suggestions welcome....
>
> --
> Accept button does not have focus when adding from library
> https://bugs.launchpad.net/bugs/599576
> You received this bug notification because you are a member of Xibo
> Maintainters, which is the registrant for Xibo.
>
> Status in Xibo Open Source Digital Signage: Confirmed
>
> Bug description:
> Hello,
>
>
> In 1.0.x it was possible (as reported to me by other user, never checked
it myself) to accept media selection from library by pressing Enter key
(when assigning to region) after selecting some checkboxes. Focus on Accept
key wasn't nessessary. It's no longer works in 1.2rc.
> Is it possible to restore that behavior in 1.2? Small wish if possible :)
>
> Thanks.
>
>
>

[Alex Harrington (alexharrington)]

Instead of hiding the button can you position it of the visible area?

[Alex Harrington (alexharrington)]

> After some investigation it appears that this does still work in Chrome (perhaps someone could confirm in Firefox?)

Not in my version of Chrome on unittest install of 1.2.0-rc1. When I choose some media items and press enter nothing happens.

[Alex Harrington (alexharrington)]

Running code from your rc2 branch I still don't have this working in Chrome or Firefox.

[Dan Garner (dangarner)]

Strange, I just downloaded Firefox and it works here... must be a linux/windows thing. I will try to position the buttons off screen without getting too many scrollbars!

[Alex Harrington (alexharrington)]

Are you definitely looking at the same dialogue? It's on adding existing media from the library.

This email carries a disclaimer, a copy of which may be read at http://learning.longhill.org.uk/disclaimer

[Bartek (czajka)]

I've noticed that issue in two different windows pc's, so i'm not sure that its os related, or maybe Alex uses windows and you're using linux? ;)

[Bartek (czajka)]

I've also noticed it in relogin window after timeout and some other dialog that i can't recall.

[Dan Garner (dangarner)]

Yeah, that is definitely the one I am looking at - I have also noticed on
the login window. I think the bottom line is that if those forms do not have
a submit element to them then they will not submit on enter with any sort of
reliability.

The question is whether we can fool the form by putting a submit element on
there and then hiding it from view, or if we have to engage in some hacky
JavaScript to bind to the enter key.