1.2.0-rc1 generates warning from Kit from webservice

[Matthew Holder]

I have set up a server from the biela branch, this installs correctly and enables me to create users, layouts etc.

However, when I try and register a display I get the following error:

<errormsg>Undefined index: HTTPS</errormsg>
<errornum>8</errornum>
<errortype>Notice</errortype>
<scriptname>/var/www/testing/xibo-biela/server/lib/app/kit.class.php</scriptname>
<scriptlinenum>422</scriptlinenum>

I think this may be related to bug #589581.

I have tried using the Python client and .NET 1.0.7.

[Alex Harrington (alexharrington)]

I think it's more likely to be the webservice schema version being incremented.

If you pull the python client from https://code.launchpad.net/~alexharrington/xibo/pyclient-1.1.1a2 and then change line 2257 of XiboClient.py to "2" instead of "1" it should then connect up OK:
http://bazaar.launchpad.net/~alexharrington/xibo/pyclient-1.1.1a2/annotate/head:/client/python/XiboClient.py#L2257

Alex

[Alex Harrington (alexharrington)]

There will be updated Windows and Linux builds for 1.2.0-rc1 on the client side - older clients will not be supported.

[Alex Harrington (alexharrington)]

Can you please try changing lib/app/kit.class.php line 422 as follows:

        if((isset($_SERVER['HTTPS'])) && ($_SERVER['HTTPS'] != ''))
        {
            $fullUrl .= 's';
        }

I think that should remove the warning message that line is generating.

[Alex Harrington (alexharrington)]

Can you also try:

        if(isset($_SERVER['HTTPS']))
        {
            $fullUrl .= 's';
        }

Which I think should give identical results.

[Matthew Holder (matt-mattmole)]

Hi Alex,

Yes, I will do this when I get a minute.

Matt

[Matthew Holder (matt-mattmole)]

Hi Alex,

Your code snippet does indeed stop the warning from appearing in the log section of the management interface

Matt

[Alex Harrington (alexharrington)]

Thanks Matt - I've pushed the fix in.