RequiredFiles ommits files for default layout

Bug #552853 reported by Alex Harrington on 2010-03-31
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fix Released
Dan Garner
Fix Released
Alex Harrington
Fix Released
Dan Garner

Bug Description

RequiredFiles omits the files required for the default layout when there is a schedule item that falls inside the "plus4hours" lookahead.

Perhaps RequiredFiles should always return the files for the default layout? (It would certainly help me on the Python Client if it did).


Changed in xibo:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 1.1.1

Commenting out lines 248, 249, 252 - 256 in xmds.php fixes this for me.

248 //if ($displayInfo['inc_schedule'] == 1)
249 //{
250 $SQL .= sprintf(" AND ((schedule_detail.starttime < '%s' AND schedule_detail.endtime > '%s' )", $plus4hours, $currentdate);
251 $SQL .= " OR (schedule_detail.starttime = '2050-12-31 00:00:00' AND schedule_detail.endtime = '2050-12-31 00:00:00' ))";
252 //}
253 //else
254 //{
255 // $SQL .= sprintf(" AND (schedule_detail.starttime < '%s' AND schedule_detail.endtime > '%s' )", $plus4hours, $currentdate);
256 //}

Bartek (czajka) wrote :

Fastest bugfix that i've ever seen ;)
Worked for me too, hope there is no hidden negative effects :)


That should have the desired effect - basically forcing the media for the
default layout to always be downloaded regardless of if it is in the
schedule or not.

This will mean that if someone has a huge default layout that will take a
long time to download a fresh client will show nothing until that is
downloaded - even if the default is not going to be shown.

Changed in xibo:
status: Confirmed → Triaged
Dan Garner (dangarner) on 2010-05-11
Changed in xibo:
assignee: nobody → Dan Garner (dangarner)
status: Triaged → Fix Committed
Dan Garner (dangarner) on 2010-05-30
Changed in xibo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related questions