Error 500 or blank page accessing Schedule with debug switched Off

[Alex Harrington]

I'm getting an error 500 in IE and a blank page in Firefox accessing the Schedule page when no displays are defined.

[Alex Harrington (alexharrington)]

Triggers the following in the log.

<errormsg>No licensed Displays</errormsg>
<errornum>256</errornum>
<errortype>User Error</errortype>
<scriptname>/sites/xibo.longhill.org.uk/htdocs/xibo-server/server/lib/pages/schedule.class.php</scriptname>
<scriptlinenum>100</scriptlinenum>

[Dan Garner (dangarner)]

This is more of a fault with the error logging procedure.

With debug off halt errors should still be displayed to the user.

[Dan Garner (dangarner)]

Having thought about it this is actually a fault of both.

The Debug class should always output E_USER_ERROR to the browser - this is used widely to indicate an error that should cause a halt and output something meaningful to the browser. Currently it is only doing this when Debug is On.

Also the Schedule class currently checks for enabled displays in the __construct. This is OK but it is not good generating a HALT error there - as the message will be outputted before any UI is built.

Solution:
Fix the Debug class to do what was intended.
Improve the Schedule class to delay the output until the displayPage method is called (there by outputting the error within the UI)