client log incorrectly contains "Shell Commands no in allow list"

Bug #1374590 reported by RLaurette
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
Undecided
Dan Garner

Bug Description

Windows 7, 32-bit
 XiboClient 1.5.0 (as reported by the Client Options "About" button)

In Client Options, Advanced tab, place a check in the tickbox Enable Shell Commands, and type the desired program's name in the Shell Command Allow List.

In a region in a layout, place a shell command media and specify the name of the program that is in the shell command allow list.

Schedule that layout. After it has been shown, check the XiboLog.txt file. Notice there is an entry "Error: <message>Shell Commands not in allow list:" etc.

This entry exists in the log even though the shell command was successfully executed. (incorrect behaviour)

This entry does not exist if the shell command allow list is left empty. (correct behaviour)

This entry exists if you attempt to execute a command not in the allow list. (correct behaviour - so it's not a security problem, just a logging problem.)

Tags: dotnetclient

Related branches

Dan Garner (dangarner)
Changed in xibo:
assignee: nobody → Dan Garner (dangarner)
milestone: none → 1.7.0-alpha2
Dan Garner (dangarner)
tags: added: dotnetclient
Changed in xibo:
status: New → Fix Committed
Dan Garner (dangarner)
Changed in xibo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.