Xibo

IE8 on XP, rss doesn't fill region space

Bug #1342056 reported by Dan Garner on 2014-07-15

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Xibo	Fix Released	High	Dan Garner	Xibo 1.6.2 "Pons-Winnecke"

Bug Description

I have a region at the top of a display (with other regions), measuring 1922 x 146. Inside it I have a BBC News feed specified (http://feeds.bbci.co.uk/news/rss.xml).

1. When the feed shows it only occupies a small width of the region rather than the whole region.
2. As I change the height of the region the text size (which I've specified as 22) changes smaller or larger.

I don't want the region to be so large it stops me having other regions, how can the RSS text be made to use the width of the region and not change size?

Tags:

Related branches

lp:~dangarner/xibo/server-162

Merged into lp:xibo/1.7 at revision 336

Xibo Maintainters: Pending requested 2014-07-15

Diff: 9040 lines (+4180/-1203)

101 files modified

client/dotNET/KeyStore.cs (+178/-0)
client/dotNET/MainForm.cs (+53/-39)
client/dotNET/OptionForm.Designer.cs (+76/-41)
client/dotNET/OptionForm.cs (+5/-1)
client/dotNET/Properties/Settings.Designer.cs (+24/-0)
client/dotNET/Properties/Settings.settings (+6/-0)
client/dotNET/XiboClient.csproj (+1/-0)
client/dotNET/app.config (+6/-0)
default.pot (+319/-288)
example_oauth/index.php (+239/-18)
example_oauth/nice-json.php (+73/-0)
example_oauth/test_files/test.csv (+6/-0)
server/3rdparty/simplepie/library/SimplePie/File.php (+4/-0)
server/3rdparty/simplepie/library/SimplePie/HTTP/Parser.php (+21/-0)
server/config/config.class.php (+3/-24)
server/install.php (+2/-2)
server/install/database/69.sql (+4/-0)
server/install/database/70.sql (+15/-0)
server/install/master/data.sql (+1/-1)
server/lib/app/kit.class.php (+5/-0)
server/lib/app/session.class.php (+1/-1)
server/lib/data/dataset.data.class.php (+165/-1)
server/lib/data/datasetcolumn.data.class.php (+88/-2)
server/lib/data/datasetdata.data.class.php (+177/-0)
server/lib/data/datasetgroupsecurity.data.class.php (+63/-2)
server/lib/data/file.data.class.php (+14/-0)
server/lib/data/layout.data.class.php (+17/-2)
server/lib/data/region.data.class.php (+59/-3)
server/lib/include.php (+7/-4)
server/lib/modules/module.class.php (+96/-64)
server/lib/oauth.inc.php (+1/-1)
server/lib/pages/admin.class.php (+1/-1)
server/lib/pages/campaign.class.php (+5/-5)
server/lib/pages/dataset.class.php (+33/-47)
server/lib/pages/display.class.php (+35/-6)
server/lib/pages/displaygroup.class.php (+37/-28)
server/lib/pages/fault.class.php (+3/-59)
server/lib/pages/group.class.php (+4/-4)
server/lib/pages/help.class.php (+3/-3)
server/lib/pages/index.class.php (+1/-1)
server/lib/pages/layout.class.php (+9/-6)
server/lib/pages/log.class.php (+45/-1)
server/lib/pages/module.class.php (+1/-1)
server/lib/pages/oauth.class.php (+1/-1)
server/lib/pages/resolution.class.php (+3/-3)
server/lib/pages/schedule.class.php (+91/-217)
server/lib/pages/sessions.class.php (+6/-4)
server/lib/pages/stats.class.php (+47/-7)
server/lib/pages/statusdashboard.class.php (+24/-18)
server/lib/pages/template.class.php (+3/-3)
server/lib/pages/timeline.class.php (+6/-6)
server/lib/pages/transition.class.php (+1/-1)
server/lib/pages/user.class.php (+12/-12)
server/lib/service/rest.class.php (+464/-8)
server/lib/service/restjson.class.php (+20/-16)
server/lib/service/xmdssoap.class.php (+15/-4)
server/locale/dbtranslate.php (+1/-0)
server/manual/content/admin/api_datasets.php (+615/-0)
server/manual/content/admin/api_library.php (+33/-15)
server/manual/content/admin/release_notes_1.6.1.php (+78/-0)
server/manual/content/admin/release_notes_1.6.2.php (+76/-0)
server/manual/content/routes.php (+3/-0)
server/manual/content/toc_developer_api.php (+1/-0)
server/manual/content/toc_developer_releasenotes.php (+2/-0)
server/manual/css/manual.css (+5/-0)
server/manual/template.php (+1/-1)
server/modules/datasetview.module.php (+23/-25)
server/modules/embedded.module.php (+27/-3)
server/modules/flash.module.php (+6/-21)
server/modules/genericfile.module.php (+6/-27)
server/modules/image.module.php (+6/-21)
server/modules/module_user_general.php (+42/-9)
server/modules/powerpoint.module.php (+18/-22)
server/modules/preview/HtmlTemplateForGetResource.html (+11/-4)
server/modules/preview/HtmlTemplateSimple.html (+30/-0)
server/modules/preview/html-preview.js (+7/-12)
server/modules/preview/vendor/jquery-1.11.1.min.js (+4/-0)
server/modules/preview/xibo-text-render.js (+55/-19)
server/modules/preview/xibo-webpage-render.js (+66/-0)
server/modules/text.module.php (+3/-2)
server/modules/ticker.module.php (+36/-8)
server/modules/video.module.php (+6/-21)
server/modules/webpage.module.php (+51/-12)
server/services.php (+0/-2)
server/theme/default/css/xibo.css (+12/-0)
server/theme/default/html/dataset_form_csv_import.php (+6/-4)
server/theme/default/html/display_page.php (+10/-1)
server/theme/default/html/displaygroup_form_display_assign.php (+2/-2)
server/theme/default/html/fault_page.php (+6/-6)
server/theme/default/html/layout_designer.php (+3/-0)
server/theme/default/html/log_form_display_last100.php (+47/-0)
server/theme/default/html/media_form_embedded_add.php (+6/-0)
server/theme/default/html/media_form_embedded_edit.php (+6/-0)
server/theme/default/html/media_form_ticker_edit.php (+8/-2)
server/theme/default/html/schedule_form_add_event.php (+96/-0)
server/theme/default/html/schedule_form_edit_event.php (+96/-0)
server/theme/default/html/schedule_form_schedule_now.php (+62/-0)
server/theme/default/html/status_dashboard.php (+3/-3)
server/theme/default/js/xibo-layout-designer.js (+1/-1)
server/theme/default/libraries/bootstrap/js/bootstrap-ckeditor-fix.js (+3/-2)
server/upgrade.php (+2/-2)

Merged into lp:xibo/1.6 at revision 339

Xibo Maintainters: Pending requested 2014-07-15

Diff: 7452 lines (+3498/-876)

85 files modified

default.pot (+319/-288)
example_oauth/index.php (+239/-18)
example_oauth/nice-json.php (+73/-0)
example_oauth/test_files/test.csv (+6/-0)
server/3rdparty/simplepie/library/SimplePie/File.php (+4/-0)
server/3rdparty/simplepie/library/SimplePie/HTTP/Parser.php (+21/-0)
server/config/config.class.php (+3/-24)
server/install.php (+2/-2)
server/install/database/70.sql (+15/-0)
server/install/master/data.sql (+1/-1)
server/lib/app/session.class.php (+1/-1)
server/lib/data/dataset.data.class.php (+165/-1)
server/lib/data/datasetcolumn.data.class.php (+88/-2)
server/lib/data/datasetdata.data.class.php (+177/-0)
server/lib/data/datasetgroupsecurity.data.class.php (+63/-2)
server/lib/data/file.data.class.php (+14/-0)
server/lib/data/layout.data.class.php (+17/-2)
server/lib/data/region.data.class.php (+59/-3)
server/lib/include.php (+6/-3)
server/lib/modules/module.class.php (+4/-4)
server/lib/oauth.inc.php (+1/-1)
server/lib/pages/admin.class.php (+1/-1)
server/lib/pages/campaign.class.php (+5/-5)
server/lib/pages/dataset.class.php (+31/-45)
server/lib/pages/display.class.php (+35/-6)
server/lib/pages/displaygroup.class.php (+4/-4)
server/lib/pages/fault.class.php (+3/-59)
server/lib/pages/group.class.php (+4/-4)
server/lib/pages/help.class.php (+3/-3)
server/lib/pages/index.class.php (+1/-1)
server/lib/pages/layout.class.php (+9/-6)
server/lib/pages/log.class.php (+45/-1)
server/lib/pages/module.class.php (+1/-1)
server/lib/pages/oauth.class.php (+1/-1)
server/lib/pages/resolution.class.php (+3/-3)
server/lib/pages/schedule.class.php (+87/-216)
server/lib/pages/sessions.class.php (+6/-4)
server/lib/pages/stats.class.php (+4/-4)
server/lib/pages/statusdashboard.class.php (+24/-18)
server/lib/pages/template.class.php (+3/-3)
server/lib/pages/timeline.class.php (+2/-2)
server/lib/pages/transition.class.php (+1/-1)
server/lib/pages/user.class.php (+12/-12)
server/lib/service/rest.class.php (+464/-8)
server/lib/service/restjson.class.php (+20/-16)
server/lib/service/xmdssoap.class.php (+15/-4)
server/locale/dbtranslate.php (+1/-0)
server/manual/content/admin/api_datasets.php (+615/-0)
server/manual/content/admin/api_library.php (+33/-15)
server/manual/content/admin/release_notes_1.6.2.php (+76/-0)
server/manual/content/routes.php (+2/-0)
server/manual/content/toc_developer_api.php (+1/-0)
server/manual/content/toc_developer_releasenotes.php (+1/-0)
server/manual/css/manual.css (+5/-0)
server/manual/template.php (+1/-1)
server/modules/datasetview.module.php (+21/-2)
server/modules/embedded.module.php (+27/-3)
server/modules/module_user_general.php (+19/-5)
server/modules/powerpoint.module.php (+11/-0)
server/modules/preview/HtmlTemplateForGetResource.html (+11/-4)
server/modules/preview/HtmlTemplateSimple.html (+30/-0)
server/modules/preview/html-preview.js (+7/-12)
server/modules/preview/vendor/jquery-1.11.1.min.js (+4/-0)
server/modules/preview/xibo-text-render.js (+50/-11)
server/modules/preview/xibo-webpage-render.js (+66/-0)
server/modules/text.module.php (+3/-2)
server/modules/ticker.module.php (+34/-6)
server/modules/webpage.module.php (+51/-12)
server/services.php (+0/-2)
server/theme/default/css/xibo.css (+12/-0)
server/theme/default/html/dataset_form_csv_import.php (+6/-4)
server/theme/default/html/display_page.php (+10/-1)
server/theme/default/html/fault_page.php (+6/-6)
server/theme/default/html/layout_designer.php (+3/-0)
server/theme/default/html/log_form_display_last100.php (+47/-0)
server/theme/default/html/media_form_embedded_add.php (+6/-0)
server/theme/default/html/media_form_embedded_edit.php (+6/-0)
server/theme/default/html/media_form_ticker_edit.php (+8/-2)
server/theme/default/html/schedule_form_add_event.php (+96/-0)
server/theme/default/html/schedule_form_edit_event.php (+96/-0)
server/theme/default/html/schedule_form_schedule_now.php (+62/-0)
server/theme/default/html/status_dashboard.php (+3/-3)
server/theme/default/js/xibo-layout-designer.js (+1/-1)
server/theme/default/libraries/bootstrap/js/bootstrap-ckeditor-fix.js (+3/-2)
server/upgrade.php (+2/-2)

Dan Garner (dangarner) on 2014-07-15

Changed in xibo:
milestone:	none → 1.6.2
assignee:	nobody → Dan Garner (dangarner)
importance:	Undecided → High
tags:	added: dotnetclient

Revision history for this message

Dan Garner (dangarner) wrote on 2014-07-15:

I've added some optional CSS to the BODY tag so that we can determine which browser version the user is using. If IE8 or below the client will apply the ZOOM properly. Otherwise it will apply the transform properties.

Revision history for this message

Dan Garner (dangarner) wrote on 2014-07-15:

HtmlTemplateForGetResource.html Edit (146.5 KiB, text/html)

Apply this file to:

/modules/preview/HtmlTemplateForGetResource.html

Changed in xibo:
status:	New → Fix Committed

Revision history for this message

Barry Wood (barry-x8) wrote on 2014-07-15:

Dan
I've added that file onto the Server (replacing the one that was there), and rebooted both Client & Server. Thing is, the display that was before showing a Dataset view and the RSS feed, now shows neither? I've changed nothing else and even removed the filter I had on the Dataset view and none of the data shows. I've even created a new layout with just the dataset, and another with just the RSS feed, and neither now displays anything.

I'll go back to the original file and see if it works as before...

Revision history for this message

Barry Wood (barry-x8) wrote on 2014-07-15:

Dan,

Just put the old file back and rebooted and both the RSS region and the dataset region are now showing data as they did before.

Revision history for this message

Dan Garner (dangarner) wrote on 2014-07-15:

When you had the replacement file in there, did you get anything in the CMS preview? Or what is just the client that didn't show as expected?

Can you also confirm you are on 1.6.1?

Revision history for this message

Barry Wood (barry-x8) wrote on 2014-07-15:

Dan
Yes I upgraded to 1.6.1 a week or so ago.

Nothing was showing in the Preview, the local Client I have on the Server nor the Client laptop.

Luckily at the moment I have both machines available to me for testing this stuff out before I go back to the golf club and use the system there.

Revision history for this message

Dan Garner (dangarner) wrote on 2014-07-15:

Can you do the following?

Temporarily set the update interval on your feed to 0
Put the file back
Open the client options, and enable mouse
Restart the client
Wait for the blank feed area to show black
Right click it
View Source
Save the file as test.html
Send the file to <email address hidden>

Revision history for this message

Dan Garner (dangarner) wrote on 2014-07-15:

Ah, I think you will also need:

http://bazaar.launchpad.net/~dangarner/xibo/server-162/download/dan%40xibo.org.uk-20140609195542-c39yu4ibmwa7pfv6/text.module.php-20090110000704-xivwazzbbvzi0480-1/text.module.php

http://bazaar.launchpad.net/~dangarner/xibo/server-162/download/dan%40xibo.org.uk-20140701171206-ffhpj2d203bkhf9r/ticker.module.php-20090110145523-cjwpb9tj6sv504ff-1/ticker.module.php

http://bazaar.launchpad.net/~dangarner/xibo/server-162/download/dan%40xibo.org.uk-20140701171206-ffhpj2d203bkhf9r/datasetview.module.p-20110822221057-oivmpiyu582gzquu-1/datasetview.module.php

all go in modules/

Revision history for this message

Barry Wood (barry-x8) wrote on 2014-07-15:

Done

Revision history for this message

Barry Wood (barry-x8) wrote on 2014-07-15:

#10

Dan
Replaced those 3 files (kept originals as well, just in case :-)). Rebooted (to be sure they get used). Ran the preview again & I've sent you the test.html file

Revision history for this message

Barry Wood (barry-x8) wrote on 2014-07-15:

#11

Just seen your email, I'll take a look ...

Revision history for this message

Dan Garner (dangarner) wrote on 2014-07-15:

#12

After debugging with Barry, he confirms this issue resolved on his XP machine.

Dan Garner (dangarner) on 2014-07-17

Changed in xibo:
status:	Fix Committed → Fix Released

Revision history for this message

Martyn Breckenridge (w-m-f) wrote on 2014-07-31:

#13

Hi,

I have the same problem, followed the steps provided, replacing all the files in the appropriate place, however, problem still exists.

Revision history for this message

Alex Harrington (alexharrington) wrote on 2014-07-31: Re: [Bug 1342056] Re: IE8 on XP, rss doesn't fill region space

#14

It's fixed in 1.6.2
On 31 Jul 2014 20:45, "Martyn Breckenridge" <email address hidden> wrote:

> Hi,
>
> I have the same problem, followed the steps provided, replacing all the
> files in the appropriate place, however, problem still exists.
>
> --
> You received this bug notification because you are subscribed to Xibo.
> https://bugs.launchpad.net/bugs/1342056
>
> Title:
> IE8 on XP, rss doesn't fill region space
>
> Status in Xibo Open Source Digital Signage:
> Fix Released
>
> Bug description:
> I have a region at the top of a display (with other regions),
> measuring 1922 x 146. Inside it I have a BBC News feed specified
> (http://feeds.bbci.co.uk/news/rss.xml).
>
> 1. When the feed shows it only occupies a small width of the region
> rather than the whole region.
> 2. As I change the height of the region the text size (which I've
> specified as 22) changes smaller or larger.
>
> I don't want the region to be so large it stops me having other
> regions, how can the RSS text be made to use the width of the region
> and not change size?
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/xibo/+bug/1342056/+subscriptions
>