Users unable to design existing layout

Bug #1285698 reported by Anthony
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Xibo
Fix Committed
Undecided
Dan Garner

Bug Description

Layouts that have already been created cannot be edited (Design) by users, even if they have or should have permissions for those layouts. This includes layouts that have been copied (both with and without the "Make new copies of all media" option checked.
The users ARE able to create and modify layouts they have created.

After the user tries to go to modify a layout design, the following message appears in Advanced:
<errormsg>Undefined variable: db</errormsg>
<errornum>8</errornum>
<errortype>Notice</errortype>
<scriptname>/opt/apache/html/modules/module_user_general.php</scriptname>
<scriptlinenum>797</scriptlinenum>

We have also tested this with a brand new install and reproduced the error with the xibo_admin and a test user.

Revision history for this message
Alex Harrington (alexharrington) wrote : Re: [Bug 1285698] [NEW] Users unable to design existing layout

What version of Xibo please?
On 27 Feb 2014 14:45, "Anthony" <email address hidden> wrote:

> Public bug reported:
>
> Layouts that have already been created cannot be edited (Design) by users,
> even if they have or should have permissions for those layouts. This
> includes layouts that have been copied (both with and without the "Make new
> copies of all media" option checked.
> The users ARE able to create and modify layouts they have created.
>
> After the user tries to go to modify a layout design, the following
> message appears in Advanced:
> <errormsg>Undefined variable: db</errormsg>
> <errornum>8</errornum>
> <errortype>Notice</errortype>
> <scriptname>/opt/apache/html/modules/module_user_general.php</scriptname>
> <scriptlinenum>797</scriptlinenum>
>
> We have also tested this with a brand new install and reproduced the
> error with the xibo_admin and a test user.
>
> ** Affects: xibo
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are subscribed to Xibo.
> https://bugs.launchpad.net/bugs/1285698
>
> Title:
> Users unable to design existing layout
>
> Status in Xibo Open Source Digital Signage:
> New
>
> Bug description:
> Layouts that have already been created cannot be edited (Design) by
> users, even if they have or should have permissions for those layouts. This
> includes layouts that have been copied (both with and without the "Make new
> copies of all media" option checked.
> The users ARE able to create and modify layouts they have created.
>
> After the user tries to go to modify a layout design, the following
> message appears in Advanced:
> <errormsg>Undefined variable: db</errormsg>
> <errornum>8</errornum>
> <errortype>Notice</errortype>
> <scriptname>/opt/apache/html/modules/module_user_general.php</scriptname>
> <scriptlinenum>797</scriptlinenum>
>
> We have also tested this with a brand new install and reproduced the
> error with the xibo_admin and a test user.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/xibo/+bug/1285698/+subscriptions
>

Revision history for this message
Anthony (pantheon-whaley) wrote :

We just upgraded to 1.6 rc1.

I had a similar problem with 1.4.2 as well. We mostly have one user (me) working as super admin, but I set up a user when we were on 1.4.2 who couldn't edit my layouts but could make and edit his own. He actually can no longer edit the layouts he created when we were on 1.4.2 either. I never tried troubleshooting it much then because nobody wanted to work with the signage system at that point.

Revision history for this message
Alex Harrington (alexharrington) wrote : Re: [Bug 1285698] Re: Users unable to design existing layout

You need to unassign and reassign the layout design access rights in the
system.

It should work then. The upgrade routine isn't complete yet and we do say
not to upgrade production systems to an rc release

Revision history for this message
Matthew Grimley (mrg-4) wrote :

I believe this affects me too.. I was seeing it on an upgraded Xibo (1.4.2 to 1.6.1), so i just did a completely fresh install and it still isnt working for me.

So, a totally clean install of 1.6.1. - 2 user accounts; xibo_admin and mrg

Xibo_admin creates a layout and assigns all permissions to mrg for that layout, for the Region, and for the "text" item in the region.

Login as mrg - you can see the layout, load the design function and the page is displayed, but the text content of the region is not visible.

Clicking Edit Timeline just briefly displays a loading bar behind the menu then nothing else.

Identical error as OP posted is visible under "Admin".

(P.S. These bug forums can be a bit terse sometimes, so let me take the opportunity to say thanks for this amazing bit of software and the v1.6 upgrade is looking absolutely fab!)

Is there anything else i can provide which would help troubleshoot?

Revision history for this message
Alex Harrington (alexharrington) wrote :

You're certain you've given permission on the text item itself too - and the region - and the layout (they all have ACLs now).

If so, it could be related to this:
https://bugs.launchpad.net/xibo/+bug/1333222

Failing that we'd need a troubleshoot.txt showing the issue

Changed in xibo:
status: New → Incomplete
milestone: none → 1.6.2
Revision history for this message
Matthew Grimley (mrg-4) wrote :

Hey Alex,

Thanks for the quick reply ;)

I've re-checked the access rights, assigned to mrg - assigned at Layout, Region and Text item level. View, Edit & Delete.

I didn't really understand the full context of the linked bug report however, the last line suggested 2 changes to php.ini. I made those and restarted MYSQL and APACHE, but the issue persists.

As for troubleshoot.txt, i have enabled debugging, recreated the issue (in a different browser and session) and generated the attached file. All i removed was email addresses and the maintenance key.

Revision history for this message
Alex Harrington (alexharrington) wrote :

Thanks Matthew

I've marked it up for investigation so hopefully there will be a fix in 1.6.2

Revision history for this message
Dan Garner (dangarner) wrote :

This has been fixed already - patch the attached file for a pre-release fix.

Changed in xibo:
status: Incomplete → Fix Committed
assignee: nobody → Dan Garner (dangarner)
Revision history for this message
Matthew Grimley (mrg-4) wrote :

Ahh crap, sorry, i missed the closed ticket!
I can confirm that the fix listed in https://bugs.launchpad.net/xibo/+bug/1328216 works perfectly and solves this for me.

Many thanks,

Matt

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.