DataSet CSS example sheet is incorrect

Bug #1133043 reported by Dan Garner
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
Medium
Dan Garner

Bug Description

Stylesheet for the Table

Currently the following code is used.
td#col_1 {

}

But it should be as follow.
td#column_1 {

}

Related branches

Revision history for this message
Dan Garner (dangarner) wrote :

datasetview.module.php line#452

Revision history for this message
Dan Garner (dangarner) wrote :

It would also be nice to extend the filtering options so that better subsets of data could be returned:

Example:

Example filter for Mondays Lunch menu: “WeekDay=Monday,Menu=Lunch”. But technically you could have only 2 designs, one for breakfast and lunch. You could use the following filter: “WeekDay=DayName(Now()),Menu=Lunch”. Of course the proper quotation has to be done by the user.

$filterPair = explode('=', $filterPair);

//Current code

//$where .= sprintf(" AND %s = '%s' ", $filterPair[0], $db->escape_string($filterPair[1]));

//Possible change

$where .= sprintf(" AND %s = %s ", $filterPair[0], $filterPair[1]);

Dan Garner (dangarner)
Changed in xibo:
importance: Undecided → Medium
Dan Garner (dangarner)
Changed in xibo:
status: Triaged → Fix Committed
Revision history for this message
Barry Wood (barry-x8) wrote :

Dan,
When might this fix be implemented in Xibo? I ask as this change will make a massive difference to me using datasets. At the moment I find the functionality too limiting, but with the ability to filter data with normal SQL syntax it would make everything much easier to manage.

Revision history for this message
Dan Garner (dangarner) wrote :

It is implemented in the attached branch (150) and will be released when 1.5.0 is ready - there is no set date for this yet, but I would imagine a few months maximum.

Dan Garner (dangarner)
Changed in xibo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.