Ticker fails is LINK attribute is missing

Bug #1076772 reported by Dan Garner
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
High
Dan Garner

Bug Description

It would seem that 1.4.0 requires that the RSS feed contain <link></link> for all item fields or the following error is generated.

Rss - LoadRssIntoTempFile
Message:Index was out of range. Must be non-negative and less than the size of the collection.Parameter name: index.

It would be nice if the new version did not require this field, as some of our RSS sources do not contain this field.

Related branches

Dan Garner (dangarner)
Changed in xibo:
milestone: none → 1.4.1
Revision history for this message
Jason Wallace (jwallace-w) wrote :

I have included a sample of XML that doesn't work, verses a sample of XML that does. Sorry I can't provide a server, our servers using this are internal only.

Not working....

<?xml version="1.0" encoding="ISO-8859-1" ?>
<rss version="2.0">

<channel>
  <title>Example1</title>
  <description>Example of Not Working</description>
  <item>
    <title>Some Random Title</title>
    <description>Some Random Description</description>
  </item>
  <item>
    <title>Some Random Title</title>
    <description>Some Random Description</description>
  </item>
</channel>

</rss>

Working.....

<?xml version="1.0" encoding="ISO-8859-1" ?>
<rss version="2.0">

<channel>
  <title>Example1</title>
  <description>Example of Not Working</description>
  <item>
    <title>Some Random Title</title>
    <link></link>
    <description>Some Random Description</description>
  </item>
  <item>
    <title>Some Random Title</title>
    <link></link>
    <description>Some Random Description</description>
  </item>
</channel>

</rss>

Revision history for this message
Dan Garner (dangarner) wrote :

That will do very nicely, thanks.

Revision history for this message
Dan Garner (dangarner) wrote :

I have replaced the RSS feed parsing library which should provide better support for missing elements. If you could download the patch and extract the files over your existing client installation and let me know if it has improved the situation.

Changed in xibo:
assignee: nobody → Dan Garner (dangarner)
status: New → Confirmed
status: Confirmed → Fix Committed
importance: Undecided → High
Revision history for this message
Jason Wallace (jwallace-w) wrote :

Patch appears to have worked. No errors and fully functional from multiple RSS sources, including our sources without <link>. This just made my day :) Thanks for the quick fix

Dan Garner (dangarner)
Changed in xibo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.