xfdesktop incorrect desktop icon font size

Bug #202970 reported by Urbán Dániel
2
Affects Status Importance Assigned to Milestone
Xfce4 Desktop
Confirmed
Unknown
xfdesktop4 (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

1) Release: Xubuntu 8.04

2) Source package: xfdesktop

3) Package version: 4.4.2-5ubuntu1

4) I expect, that when in Applications -> Settings -> Settings manager -> Desktop -> Behavior I uncheck the "Use system font size" option, xfdesktop will use the size given in the "Custom font size" spinbox.

5) Instead of that, when I uncheck it first, it will use a size of 0px for the desktop icons' font size, so the text is unreadable (I will attach a screenshot with the checked and the unchecked state).

6) How to reproduce the bug?
This problem only happens, if the "Custom font size" option never changed, because if a change happens, the xfce-mcs-manager will store the value of the font size, and when unchecking the "Use system font size" checkbox, xfdesktop will load the stored setting. But if is no stored setting, xfdesktop will use the 0px.

7) Possible solution (#1)
Make xfce-mcs-manager store the value of the spinbox, when the spinbox change its state from insensitive to sensitive. (I think think this is the better solution.)
The first source file (behavior-settings.c), that I will attach, contains this solution.

8) Possible solution (#2)
Modify xfdesktop, to use a more sensible default value, such as 12px.
The second source file (xfce-desktop-settings.c), that I will attach contains this solution.

The two fixes are tested on my machine, and both worked well, but of course they needs more testing and review because I'm not a very experienced programmer :-)

Please let me know if I have to give more explanation or any other information!

Thanks,
Urbán Dániel

Revision history for this message
Urbán Dániel (urban.dani) wrote :
Revision history for this message
Urbán Dániel (urban.dani) wrote :
Revision history for this message
Urbán Dániel (urban.dani) wrote :
Revision history for this message
Urbán Dániel (urban.dani) wrote :
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Hi,

Thanks for your bug report.
I can reproduce this issue as well.

Could you provide some patches (instead of the complete source file) please? It would be easier to review/forward upstream.
To make a patch, you can run: diff -Naur oldfile newfile > mypatch.diff
Thanks.

Changed in xfdesktop:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Urbán Dániel (urban.dani) wrote :

Hi,
Thanks for the quick reply!

Of course, I'm sending the diffs generated from behavior-settings.c and xfce-desktop-settings.c as found in the http://archive.ubuntu.com/ubuntu/pool/universe/x/xfdesktop4/xfdesktop4_4.4.2.orig.tar.gz file.

Thanks,
Urbán Dániel

Revision history for this message
Urbán Dániel (urban.dani) wrote :
Revision history for this message
Urbán Dániel (urban.dani) wrote :

Hi!

Are there any progress with this bug?
Is my patch correct?

Please let me know, if I can do anything, to fix this bug.

Thanks,
Urbán Dániel

Revision history for this message
Lionel Le Folgoc (mrpouit) wrote : Re: [Bug 202970] Re: xfdesktop incorrect desktop icon font size

On Thu, Mar 20, 2008 at 10:04 PM, Urbán Dániel <email address hidden> wrote:
> Hi!
>
> Are there any progress with this bug?
> Is my patch correct?
>
> Please let me know, if I can do anything, to fix this bug.
>
> Thanks,
> Urbán Dániel
>
>
> --
> xfdesktop incorrect desktop icon font size
> https://bugs.launchpad.net/bugs/202970
> You received this bug notification because you are subscribed to
> xfdesktop4 in ubuntu.
>

Sorry, I've been away from Internet/my computer recently. I'll try to
look at these patches this week-end.

Gauvain: could you look at them too?

Cheers,
Lionel

Revision history for this message
Gauvain Pocentek (gpocentek) wrote :

Just 2 tiny things:

1) No need to use an 'McsResult result' variable, the if/else works fine without that
2)
+#endif /* ENABLE_DESKTOP_ICONS */
+
+#ifdef ENABLE_DESKTOP_ICONS
I don't think that it's needed ;)

There is certainly a better way to set the default size, but that's OK for now I guess.

Revision history for this message
Urbán Dániel (urban.dani) wrote :

Thanks for the correction!

Yes, the default size is not the best solution, as I wrote I think the #1 patch is maybe better (for the behavior-settings.c file).

Urbán Dániel

Changed in xfdesktop:
status: Unknown → Confirmed
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Should be fixed in Xfce 4.4.3 (Xfce 4.6 doesn't seem to be affected).

Changed in xfdesktop4:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.