xfdesktop incorrect desktop icon font size
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Xfce4 Desktop |
Confirmed
|
Unknown
|
|||
xfdesktop4 (Ubuntu) |
Fix Released
|
Low
|
Unassigned |
Bug Description
1) Release: Xubuntu 8.04
2) Source package: xfdesktop
3) Package version: 4.4.2-5ubuntu1
4) I expect, that when in Applications -> Settings -> Settings manager -> Desktop -> Behavior I uncheck the "Use system font size" option, xfdesktop will use the size given in the "Custom font size" spinbox.
5) Instead of that, when I uncheck it first, it will use a size of 0px for the desktop icons' font size, so the text is unreadable (I will attach a screenshot with the checked and the unchecked state).
6) How to reproduce the bug?
This problem only happens, if the "Custom font size" option never changed, because if a change happens, the xfce-mcs-manager will store the value of the font size, and when unchecking the "Use system font size" checkbox, xfdesktop will load the stored setting. But if is no stored setting, xfdesktop will use the 0px.
7) Possible solution (#1)
Make xfce-mcs-manager store the value of the spinbox, when the spinbox change its state from insensitive to sensitive. (I think think this is the better solution.)
The first source file (behavior-
8) Possible solution (#2)
Modify xfdesktop, to use a more sensible default value, such as 12px.
The second source file (xfce-desktop-
The two fixes are tested on my machine, and both worked well, but of course they needs more testing and review because I'm not a very experienced programmer :-)
Please let me know if I have to give more explanation or any other information!
Thanks,
Urbán Dániel
Changed in xfdesktop: | |
status: | Unknown → Confirmed |
Hi,
Thanks for your bug report.
I can reproduce this issue as well.
Could you provide some patches (instead of the complete source file) please? It would be easier to review/forward upstream.
To make a patch, you can run: diff -Naur oldfile newfile > mypatch.diff
Thanks.