Build against libnotify 0.7.0 fails

Bug #671915 reported by Christoph Wickert on 2010-11-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xfce4-volumed
High
Steve Dodier-Lazaro

Bug Description

Libnotify 0.7.0 contains a number of API changes and one of them affects xfc4-nofityd. 'notify_notification_new' has lost its widget argument. To make xfce4-volumed build again you need to change

--- xfce4-volumed-0.1.10.orig/src/xvd_notify.c 2010-11-02 13:57:23.000000000 +0100
+++ xfce4-volumed-0.1.10/src/xvd_notify.c 2010-11-06 19:47:43.473430070 +0100
@@ -120,7 +120,6 @@
  Inst->notification = notify_notification_new (
      "Xfce4-Volumed",
      NULL,
- NULL,
      NULL);
 }

Of course there needs to be a proper detection of the version in configure, but I'm just a lazy package maintainer and not a developer.

Changed in xfce4-volumed:
assignee: nobody → Steve Dodier (sidi)
importance: Undecided → High
status: New → Confirmed
Samuli Suominen (ssuominen) wrote :

This one is compatible with 0.4.x, 0.5.x and 0.7.x... Doesn't even need any configure.ac magic! It's fixed in same way in Thunar's code. This is the patch we are using in Gentoo Linux.

Thanks, Samuli Suominen

Changed in xfce4-volumed:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers