[Tasklist plugin] Grouped icons are not rendered with transparent effect when their child are all minimized.

[amigamagic]

package: xfce4-panel-4.11.0
plugin: tasklist

bug (1):
Minimized icons in the tasklist are rendered with a certain transparency factor, but actually this doesn't apply to grouped icons. To mantain a consistent behaviour, when "all" the windows inside a group are minimized the grouped icon should be transparent too.

bug (2):
Let's suppose you selected to display only the minimized icons in the tasklist. Now if you open a new window of a different type from the ones currently in the tasklist, and then minimize it, its icon will be displayed without transparency. This is inconsistent with the expected behaviour.

** I attached a diff file to fix both problems. **

[amigamagic (debianmaverick)]

Created attachment 5465
Diff file with the bugfix

package: xfce4-panel-4.11.0
plugin: tasklist

Minimized icons in the tasklist are rendered with a certain transparency factor, but actually this doesn't apply to grouped icons. To mantain a consistent behaviour, when "all" the windows inside a group are minimized the grouped icon should be transparent too.

I attached a bugfix.

Cheers,
amigamagic

[amigamagic (debianmaverick)]

Created attachment 5466
Diff file with the bugfix (v2)

Fixed another bug: let's suppose you selected to display only the minimized icons in the tasklist. Now if you open a new window of a different type from the ones currently in the tasklist, and then minimize it, its icon will be displayed without transparency. This is inconsistent with the expected behaviour, so I fixed it.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Diff file with the fix for bug 1 and 2" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Andrzej (ndrwrdck)]

Pushed to git (v2). It fixes the second issue (transparency of minimized new windows) but the first one is still there (grouped icons are are opaque even when all their windows are minimized).

[Steve Dodier-Lazaro (sidi)]

Please try to git apply --check yourpatch.patch before submitting, to spot and remove all trailing whitespaces :-)

[Steve Dodier-Lazaro (sidi)]

Otherwise, just as for Andre: neither patch 5465 or 5466 fix the reported issue. They appear to be doing nothing.

Amigamagic, could you please tell us how you tested this patch?

[Simon Steinbeiß (ochosi)]

I've rebased this patch on top of current master, but I still see at least one issue I would like to fix before merging this:
- when a single window is minimized and you then open a second window of that application, the icon remains 70% translucent, so there's at least one unhandled signal/case (active_window_changed or whatever)
- the exo stuff should be replaced by style-classes and something like "button image { opacity: 0.7; }"

[Simon Steinbeiß (ochosi)]

Ok, part one is done. I'll try to replace exo too and then push this.

[Gitbot (gitbot)]

Simon Steinbeiss referenced this bugreport in commit 9921b874b7c929696eca061b8818303d3e439a93

tasklist: Make all-minimized group buttons translucent (Bug #10862)

https://git.xfce.org/xfce/xfce4-panel/commit?id=9921b874b7c929696eca061b8818303d3e439a93

[Sean Davis (bluesabre)]

Reportedly fixed upstream.