Missing ... for Preferences menu item

Reported by Fred on 2011-07-26
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xchat
Unknown
Unknown
xchat (Ubuntu)
Wishlist
Chad Dunlap

Bug Description

Menu has Settings -> Preferences
But since it opens a dialog, it should be suffixed with three dots
Should be Settings -> Preferences...

Related branches

tags: added: hig usability
Bryce Harrington (bryce) on 2011-09-13
tags: added: bitesize
Changed in xchat (Ubuntu):
status: New → Confirmed
importance: Undecided → Wishlist
Chad Dunlap (cldunlap1) wrote :

I have committed this fix and proposed the merge.

If you need anything else for this, please don't hesitate to let me know.

Changed in xchat (Ubuntu):
assignee: nobody → Chad Dunlap (cldunlap1)
status: Confirmed → Fix Committed
Fred (eldmannen+launchpad) wrote :

in XChat -> New -> Server Tab...
it has the ellipsis suffix but the action requires no user action or confirmation, so maybe it shouldn't have the ellipsis?
Same for Channel Tab...
Or what do you think?

Ctrl+J would be a great shortcut for Server -> Join a Channel...

Fred (eldmannen+launchpad) wrote :

Help -> About; the text in the dialog should have some margin on the left and right sides so the text doesn't touch the borders.
Should be like 8px, I think.

Fred (eldmannen+launchpad) wrote :

Help -> About should have a License button.

Chad Dunlap (cldunlap1) wrote :

Fred,

Chad Dunlap (cldunlap1) wrote :

Fred,

  I don't disagree with any of your comments. I think the changes to the '...' for 'Server Tab' and 'Channel Tab' should probably be their own bug, outside of this one. I can fix those easy enough.

  The 'Help -> About' is a bit above my meager programming skills but I believe this is probably another bitesize bug, outside of this report.

  Thoughts?

Chad Dunlap (cldunlap1) wrote :

I have opened a bug (LP: #881232) on the two ellipsis that need to be removed from Server Tab and Channel Tab. I have assigned this to myself and I will get it fixed and propose the merge.

Fred - If you think the other issues you mentioned need their own bugs, can you open the bug reports?

Thank You.

Fred (eldmannen+launchpad) wrote :

Thanks Chad! :)

I filed a bug #881623 for the License button.
And #881625 for the shortcut for joining a channel.

Barry Warsaw (barry) wrote :

Please see my merge proposal comment for why I think this bug should not be fixed, or at least not fixed only in Ubuntu.

https://code.launchpad.net/~cldunlap1/ubuntu/oneiric/xchat/fix-for-816506/+merge/80118

Changed in xchat (Ubuntu):
status: Fix Committed → Invalid
Fred (eldmannen+launchpad) wrote :

Sorry, Barry is more intimately familiar with the HIG than I am.

Daniel Holbach (dholbach) wrote :

Patch forwarded upstream.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.