deleting a transfer doesn't delete on both accounts

Bug #395955 reported by Merlin on 2009-07-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
wxBanker
Medium
Michael Rooney

Bug Description

Hi,
I just tried to delete a transfer and I noticed that only "one side" of the transaction was deleted.

I had two transactions:
"everyday" [normal savings account at bank]
"cash" [cash on hand]

I created a transfer but got it wrong [negative instead of positive], so I deleted it in from the "cash" account.
But when I looked at the "everyday" account, the transaction was still there.

So therefore, my net balance was wrong.

When you delete a transfer, both sides of the transfer should be deleted.

Michael Rooney (mrooney) wrote :

Thanks, this is true indeed. I'll fix this for the next release (0.6). Do you think it should silently delete both or, when deleting an account with a linked transfer, ask if you want to delete both?

Changed in wxbanker:
assignee: nobody → Michael Rooney (mrooney)
importance: Undecided → Medium
milestone: none → 0.6
status: New → Triaged
Merlin (merlin-zener) wrote :

My personal opinion is, if it's a transfer and you delete it, it should silently delete both.

Perhaps some ppl might feel that you should ask, which would then alert them that they are deleting a transfer, not just a single transaction [like an expense etc].

Michael Rooney (mrooney) wrote :

Okay, I think deleting both automatically is sound behavior. I also linked the blueprint for this which if I implement will add some nice things, so if you change the date / amount / description it will ask if you also want to apply it to the linked transfer. I imagine that is also useful, do you think?

Merlin (merlin-zener) wrote :

yes I do think!

love ya work!!!
;)

Michael Rooney (mrooney) wrote :

Okay, I've fixed this in trunk and it will be fixed when 0.6 is released. Now making a transfer actually links the two transactions to each other. However since the links didn't exist previous to 0.6, only transactions created after this fix will work in the expected way since only those transfers will have the link. This should hopefully be pretty reasonable, as someone probably will delete a new transfer recently made accidentally / incorrectly instead of deleting an old transaction.

Thanks again for reporting this!

Changed in wxbanker:
status: Triaged → Fix Committed
Michael Rooney (mrooney) wrote :

...and (I forgot to mention) feel free to join the wxBanker users group at https://launchpad.net/~wxbanker-users if you want to get announcements of new releases or submit feedback, ask questions, and such!

Michael Rooney (mrooney) on 2009-12-14
Changed in wxbanker:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related questions