wsme tox.ini pep8 target uses flake8 not hacking

Bug #1446692 reported by Chris Dent
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
WSME
New
Undecided
Unassigned

Bug Description

The pep8 rule in wsme's tox.ini is:

    [testenv:pep8]
    deps = flake8
    commands = flake8 wsme wsmeext setup.py

This means it doesn't use the hacking rules established as "the norm" in most openstack projects. It probably should, for sake of participation and getting value from those checks.

Revision history for this message
Stéphane Bisinger (kjir) wrote :

I think we should start a change set to workflow -1 with the hacking checks, so that we may use it to slowly fix all the PEP8 issues in the code, otherwise we will keep fixing bugs without fixing the style as well...

Revision history for this message
Stéphane Bisinger (kjir) wrote :

I took the liberty of doing just that. I am going to open bugs to fix some PEP8 issues and put a "Partial-Bug" external reference in the commit messages pointing to this one. Until all PEP8 warnings are resolved, this change will stay with Workflow -1 on Gerrit.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to wsme (master)

Reviewed: https://review.openstack.org/182744
Committed: https://git.openstack.org/cgit/stackforge/wsme/commit/?id=32456d3e4792654373cfd4ad0ce125f7f4cd9438
Submitter: Jenkins
Branch: master

commit 32456d3e4792654373cfd4ad0ce125f7f4cd9438
Author: Stéphane Bisinger <email address hidden>
Date: Wed May 13 18:20:10 2015 +0200

    Replace deprecated assertEquals with assertEqual

    Unit tests were still using the deprecated assertEquals instead of
    assertEqual. This removes all mentions of assertEquals to use the new name and
    be compatible with the OpenStack Style Guidelines.

    Closes-Bug: #1454766
    Partial-Bug: #1446692
    Change-Id: Ieb90a334a0d0e91845d20a3e4ea4697307ed3f2a

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on wsme (master)

Change abandoned by Chris Dent (<email address hidden>) on branch: master
Review: https://review.openstack.org/182729
Reason: This patch has not had any activity in a year so abandoning. If this is still relevant please restore and update the patch.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.