Forks on the primary output port should not be allowed
Bug #1454231 reported by
Danil Sokolov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Workcraft |
Fix Committed
|
Medium
|
Danil Sokolov | ||
Bug Description
Few corrections to the circuit plugin are required:
* Forbid direct connection between primary input and output ports
* Forbid forks on primary output ports
* Allow output ports to be drivers
* Handling the drivers of the output ports that are inside pages
Related branches
lp:~danilovesky/workcraft/trank-bug-1454231
- Workcraft core developers: Pending requested
-
Diff: 3965 lines (+1087/-886)68 files modifiedCircuitPlugin/src/org/workcraft/plugins/circuit/CircuitModule.java (+4/-0)
CircuitPlugin/src/org/workcraft/plugins/circuit/CircuitToolsProvider.java (+4/-12)
CircuitPlugin/src/org/workcraft/plugins/circuit/CircuitUtils.java (+63/-22)
CircuitPlugin/src/org/workcraft/plugins/circuit/VisualCircuit.java (+55/-18)
CircuitPlugin/src/org/workcraft/plugins/circuit/stg/CircuitToStgConverter.java (+77/-71)
CircuitPlugin/src/org/workcraft/plugins/circuit/stg/NodeStg.java (+8/-8)
CircuitPlugin/src/org/workcraft/plugins/circuit/stg/SignalStg.java (+2/-2)
CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckCircuitTask.java (+11/-11)
CircuitPlugin/src/org/workcraft/plugins/circuit/tools/CircuitConnectionTool.java (+22/-0)
CircuitPlugin/src/org/workcraft/plugins/circuit/tools/CircuitSimulationTool.java (+88/-57)
DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckDataflowDeadlockTask.java (+3/-2)
DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckDataflowHazardTask.java (+2/-2)
DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckDataflowTask.java (+4/-4)
DfsPlugin/src/org/workcraft/plugins/dfs/tools/DfsSimulationTool.java (+1/-10)
FsmPlugin/src/org/workcraft/plugins/fsm/tools/FsmSimulationTool.java (+1/-10)
FstPlugin/src/org/workcraft/plugins/fst/tools/FstSimulationTool.java (+1/-10)
MpsatPlugin/src/org/workcraft/plugins/mpsat/MpsatBuiltinPresets.java (+10/-8)
MpsatPlugin/src/org/workcraft/plugins/mpsat/MpsatDeadlockResultHandler.java (+11/-14)
MpsatPlugin/src/org/workcraft/plugins/mpsat/MpsatResultParser.java (+3/-3)
MpsatPlugin/src/org/workcraft/plugins/mpsat/MpsatSettings.java (+23/-26)
MpsatPlugin/src/org/workcraft/plugins/mpsat/MpsatSettingsSerialiser.java (+8/-5)
MpsatPlugin/src/org/workcraft/plugins/mpsat/MpsatStgReachabilityResultHandler.java (+13/-18)
MpsatPlugin/src/org/workcraft/plugins/mpsat/MpsatUndefinedResultHandler.java (+1/-1)
MpsatPlugin/src/org/workcraft/plugins/mpsat/gui/MpsatConfigurationDialog.java (+115/-84)
MpsatPlugin/src/org/workcraft/plugins/mpsat/gui/Solution.java (+13/-0)
MpsatPlugin/src/org/workcraft/plugins/mpsat/gui/SolutionsDialog.java (+10/-13)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tasks/MpsatConformationTask.java (+5/-5)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tools/CscResolutionTool.java (+6/-2)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tools/MpsatConsistencyChecker.java (+1/-1)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tools/MpsatCscChecker.java (+3/-3)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tools/MpsatCustomPropertyChecker.java (+1/-1)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tools/MpsatDeadlockChecker.java (+2/-3)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tools/MpsatNormalcyChecker.java (+2/-2)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tools/MpsatPersistencyChecker.java (+3/-3)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tools/MpsatSynthesis.java (+3/-2)
MpsatPlugin/src/org/workcraft/plugins/mpsat/tools/MpsatUscChecker.java (+2/-2)
PetriNetPlugin/src/org/workcraft/plugins/petri/tools/PetriNetSimulationTool.java (+75/-50)
PetrifyPlugin/src/org/workcraft/plugins/petrify/tools/PetrifySynthesis.java (+5/-5)
PolicyNetPlugin/src/org/workcraft/plugins/policy/tasks/CheckDeadlockTask.java (+2/-2)
PolicyNetPlugin/src/org/workcraft/plugins/policy/tools/SimulationTool.java (+2/-11)
SONPlugin/src/org/workcraft/plugins/son/SONModule.java (+1/-1)
SONPlugin/src/org/workcraft/plugins/son/VisualSON.java (+27/-35)
SONPlugin/src/org/workcraft/plugins/son/tools/SONSimulationTool.java (+30/-25)
STGPlugin/src/org/workcraft/plugins/stg/LabelParser.java (+18/-0)
STGPlugin/src/org/workcraft/plugins/stg/STGReferenceManager.java (+1/-1)
STGPlugin/src/org/workcraft/plugins/stg/STGToolsProvider.java (+3/-10)
STGPlugin/src/org/workcraft/plugins/stg/VisualSTG.java (+3/-0)
STGPlugin/src/org/workcraft/plugins/stg/tools/StgConnectionTool.java (+19/-0)
STGPlugin/src/org/workcraft/plugins/stg/tools/StgSimulationTool.java (+78/-74)
STGPlugin/src/org/workcraft/plugins/stg/tools/StgToPetriNetConverter.java (+1/-1)
WorkcraftCore/src/org/workcraft/dom/hierarchy/NamespaceHelper.java (+2/-2)
WorkcraftCore/src/org/workcraft/dom/math/AbstractMathModel.java (+23/-29)
WorkcraftCore/src/org/workcraft/dom/math/MathGroup.java (+4/-6)
WorkcraftCore/src/org/workcraft/dom/references/HierarchicalUniqueNameReferenceManager.java (+37/-26)
WorkcraftCore/src/org/workcraft/dom/visual/AbstractVisualModel.java (+16/-18)
WorkcraftCore/src/org/workcraft/dom/visual/ConnectionHelper.java (+6/-2)
WorkcraftCore/src/org/workcraft/dom/visual/DrawMan.java (+37/-44)
WorkcraftCore/src/org/workcraft/dom/visual/TouchableTransformer.java (+1/-2)
WorkcraftCore/src/org/workcraft/dom/visual/VisualGroup.java (+5/-5)
WorkcraftCore/src/org/workcraft/dom/visual/VisualModelTransformer.java (+28/-35)
WorkcraftCore/src/org/workcraft/dom/visual/VisualPage.java (+7/-22)
WorkcraftCore/src/org/workcraft/gui/graph/tools/ConnectionTool.java (+6/-2)
WorkcraftCore/src/org/workcraft/gui/graph/tools/DefaultModelConverter.java (+1/-1)
WorkcraftCore/src/org/workcraft/gui/graph/tools/SelectionTool.java (+30/-20)
WorkcraftCore/src/org/workcraft/plugins/shared/gui/PresetManagerDialog.java (+5/-2)
WorkcraftCore/src/org/workcraft/plugins/shared/gui/PresetManagerPanel.java (+23/-17)
WorkcraftCore/src/org/workcraft/plugins/shared/presets/PresetManager.java (+0/-1)
WorkcraftCore/src/org/workcraft/workspace/WorkspaceEntry.java (+10/-2)
| Changed in workcraft: | |
| status: | Triaged → Fix Committed |
| status: | Fix Committed → Triaged |
| status: | Triaged → In Progress |
| Changed in workcraft: | |
| status: | In Progress → Fix Committed |
| Changed in workcraft: | |
| importance: | Undecided → Medium |
To post a comment you must log in.
