Menu items don't reflect state changes

Bug #1613426 reported by Stephen Brandt on 2016-08-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Wingpanel Ayatana Indicator
Fix Released
High
Djax

Bug Description

Hi,

I was testing my application [1] in elementaryOS 0.4 beta 2 and noticed the menu items of the indicator did not update according to state changes inside Wingpanel. When Haguichi changes mode (for example from "Connected" to "Disconnected") a signal is send over DBus to the indicator, which will then change the icon and menu items accordingly [2].

The *icon* change is reflected correctly in Wingpanel (so there's no DBus problem), however the menu item properties (visibility, sensitivity, toggle state) are not reflected in the menu.

This bug is *not* present in elementaryOS 0.3.2. See attached screenshot for comparison between Ubuntu 16.04, elementaryOS 0.3.2 and elementaryOS 0.4 beta 2.

[1] https://www.haguichi.net/
[2] http://bazaar.launchpad.net/~ztefn/haguichi-indicator/0.3/view/head:/src/indicator-menu.vala#L217

Related branches

Stephen Brandt (ztefn) wrote :
Djax (parnold-x) wrote :

Thanks for the bug report. The attached branch should fix it.

Changed in wingpanel-indicator-ayatana:
assignee: nobody → Djax (parnold-x)
status: New → In Progress
Stephen Brandt (ztefn) wrote :

I've tested the branch. Visibility and sensitivity states seems to have been fixed indeed.

However the "active" state of the "Show Haguichi" CheckMenuItem still doesn't change when the window is hidden or shown [1].

I'm sorry for not explicitly mentioning that state had signal problems too in my report.

[1] http://bazaar.launchpad.net/~ztefn/haguichi-indicator/0.3/view/head:/src/indicator-menu.vala#L162

Djax (parnold-x) wrote :

Thanks, missed that. Updated.

Stephen Brandt (ztefn) wrote :

Works perfectly now. Thanks for fixing!

Cody Garver (codygarver) on 2016-08-18
Changed in wingpanel-indicator-ayatana:
importance: Undecided → High
milestone: none → loki-rc1
RabbitBot (rabbitbot-a) on 2016-08-18
Changed in wingpanel-indicator-ayatana:
status: In Progress → Fix Committed
Cody Garver (codygarver) on 2016-08-19
Changed in wingpanel-indicator-ayatana:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments