[PATCH] Explicitly link against libm (Fix for ld no longer implicitly linking DSOs)

Bug #528296 reported by Michel Lind
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
window-picker-applet
New
Undecided
Unassigned
Fedora
Fix Released
High

Bug Description

Fedora's Rawhide series use a new linker that no longer implicitly link DSOs, for security reasons:
http://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking

Window Picker Applet's task-item.o uses libm's cos, but right now libm is not directly linked during the build process. This no longer works:

/usr/bin/ld: task-item.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
/usr/bin/ld: note: 'cos@@GLIBC_2.2.5' is defined in DSO /lib64/libm.so.6 so try adding it to the linker command line
/lib64/libm.so.6: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
make[2]: *** [window-picker-applet] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/window-picker-applet-0.5.8/src'

See attached patch for fix

Revision history for this message
In , FTBFS (ftbfs-redhat-bugs) wrote :

gnome-applet-window-picker-0.5.6-3.fc12.src.rpm Failed To Build From Source against the rawhide tree. See http://fedoraproject.org/wiki/FTBFS for more information.
This failure is due to a change in the linker default behavior, which uncovered a fault in your package. See http://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking .
If you believe this is actually a bug in another package, do NOT change the component in this bug or close this bug. Instead, add the appropriate bug number from the other package to the "Depends on" line in this bug. If the other package does not yet have a bug created that you think matches, please create one. Doing so helps us properly track bugs and their dependencies, just as we track package dependencies. (If you close this bug, and the other package is not fixed before the next FTBFS run, a new bug will get created. Please follow the above advice to avoid such duplication.)

Revision history for this message
In , FTBFS (ftbfs-redhat-bugs) wrote :

Created attachment 391271
root.log

root.log for i386

Revision history for this message
In , FTBFS (ftbfs-redhat-bugs) wrote :

Created attachment 391272
build.log

build.log for i386

Revision history for this message
In , FTBFS (ftbfs-redhat-bugs) wrote :

Created attachment 391273
mock.log

mock.log for i386

Revision history for this message
In , FTBFS (ftbfs-redhat-bugs) wrote :

Created attachment 391274
root.log

root.log for x86_64

Revision history for this message
In , FTBFS (ftbfs-redhat-bugs) wrote :

Created attachment 391275
build.log

build.log for x86_64

Revision history for this message
In , FTBFS (ftbfs-redhat-bugs) wrote :

Created attachment 391276
mock.log

mock.log for x86_64

Revision history for this message
Michel Lind (michel-slm) wrote :
Revision history for this message
In , Michel (michel-redhat-bugs) wrote :

Fixed in Rawhide, and upstreamed to Launchpad. Will close when F-13 build becomes a stable update

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

gnome-applet-window-picker-0.5.8-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/gnome-applet-window-picker-0.5.8-2.fc13

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

gnome-applet-window-picker-0.5.8-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with
 su -c 'yum --enablerepo=updates-testing update gnome-applet-window-picker'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-3034

Revision history for this message
In , Bug (bug-redhat-bugs) wrote :

This bug appears to have been reported against 'rawhide' during the Fedora 13 development cycle.
Changing version to '13'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Revision history for this message
In , Bruno (bruno-redhat-bugs) wrote :

This hasn't been pushed to stable yet. Is there an issue with the test version?

Revision history for this message
In , Fedora (fedora-redhat-bugs) wrote :

gnome-applet-window-picker-0.5.8-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.

Changed in fedora:
importance: Unknown → High
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.