assumes working tree is unchanged

Bug #585961 reported by Jelmer Vernooij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Wikkid Wiki
Incomplete
Undecided
Unassigned

Bug Description

  affects wikkid

When attempting to access a directory that has been added in the working
tree but not committed yet, I get an exception.

FileStore.list_directory() uses the working tree and calls out to File()
which instead attempts to use the basis tree.

I'm happy to provide a patch but not sure which of the two wikkid should
be using - the working tree or the basis tree? Is using a branch with a
working tree not modified by wikkid supported at all?

Revision history for this message
Tim Penhey (thumper) wrote :

I chose to use a working tree for efficiency of getting the latest text (and for writing out changes).

Aaron said he had a branch that would allow wikkid to commit directly to the branch (without the need for a working tree).

I think it is preferable to have it commit to the branch, and update the tree if it exists. We should complain if the working tree has been modified by a third party I think.

So... where to from here?

Changed in wikkid:
status: New → Incomplete
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.