memory leak in src/ai/defaultai.cc:1439

Bug #984110 reported by David Allwicher on 2012-04-17
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Medium
Unassigned

Bug Description

A lot new calls, at maximum one call to delete. Probably needs some refactoring to stay readable. I'm still kinda confused, because this is kinda obvious and should have been detected earlier.

Related branches

Changed in widelands:
importance: Undecided → Medium
tags: added: leak

Thanks David! errors happen, and most of them are obvious in hindsight.
Merged in r6362.

  status fixcommitted

Changed in widelands:
status: New → Fix Committed
Shevonar (shevonar) on 2012-05-03
Changed in widelands:
milestone: none → build18-rc1

Before I submit a new bug... Would this bug have caused runaway memory allocation after closing the statistics window? That is at least behaviour I experience running build 17 on Arch linux.

David Allwicher (aber) wrote :

No, this is piece of code is inside the default ai, which is the computer player. I highly doubt this piece of code is reused when the statistics window is closed.

But you make a good point. It's better to report bugs against a nightly build, to make sure it's not already fixed or altered in any way.

Hans Joachim Desserud (hjd) wrote :

There are a couple of known memory leaks discovered by cppcheck which have not been fixed yet (see bug 986611 for details). It's hard for me to tell whether that is the same one though. Feel free to simply file a bug report if this is reproducible.

SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers