Add playercolor to building pictures in messages

Bug #978160 reported by wl-zocker on 2012-04-10
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

When a military building is occupied/conquered/attacked, the player gets a message which tells him this. In the message window, the military building is displayed.

If the player's tribe are the Barbarians, the spots where player colors shall be is white.
If the player plays the Atlanteans, the spots are blue, although the player's color is not blue.
The Empire has no military building with player colors (at least I could not find any).

The issue is that the Atlanteans' buildings' idle images have blue colors, while the Barbarians' ones are white. Only the idle image (without player colors) is displayed in the message window.

I think that image should always have the player colors. Therefor, only the player color mask would have to be added.

See also where the same problem happens in the building statistic.

Related branches

wl-zocker (wl-zocker) on 2012-04-10
description: updated
Nasenbaer (nasenbaer) wrote :

From what I can see, the atlantean colors are not blue, but just a blueish gray from the original pictures. So the behaviour is the same for the atlanteans and the barbarians.

However it would of course be nice to show the player color in those windows as well. :)

Changed in widelands:
status: New → Confirmed
importance: Undecided → Low
tags: added: ui
Nasenbaer (nasenbaer) on 2012-04-11
summary: - Blue color in message window although player's color is not blue
+ Add playercolor to building pictures in messages
Chuck Wilder (chuckw20) wrote :

@Nasenbaer#1 - You are correct, of course, that the Atlantean buildings use the blueish-gray color to identify surfaces that will show player color on the game map. The other tribes' buildings use either a white or off-white color for this purpose. Though I was not involved at the time they were created, I believe the use of the darker color on the Atlantean buildings was intentional to invoke a darkening effect on the base player color when seen in the game. In other words, the original hue of the player color areas in an image has a direct impact on the reflectivity of those areas when masked and overlayed with a standard player color in the game.

example: the blue player color for the Atlantean buildings is a much darker hue than the blue player color of the other tribes. Similarly, the Atlantean red is a dark red, green a dark green, etc.

So, again, it is due to the fact that NO player color mask is applied to the building images in menus, status screens, etc. that one ultimately sees the underlying player color designator on the buildings.

Jens Beyer (qcumber-some) wrote :

This bug is related to Bug #536230

Jens Beyer (qcumber-some) wrote :

This bug is different than Bug #536230
Problem here is that the renderer for the messages uses some markup to include a static file (the first animation frame) in the message. There is probably no way to include a dynamically rendered image.

Jens Beyer (qcumber-some) wrote :

Looks like this could possibly be implemented using the same mechanism like Bug #536230 now that the sprite map branch hit trunk.

Changed in widelands:
assignee: nobody → Jens Beyer (qcumber-some)
wl-zocker (wl-zocker) wrote :

It had been implemented, but then it was removed because of bug 1296655.

SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
GunChleoc (gunchleoc) on 2016-09-19
Changed in widelands:
milestone: none → build20-rc1
GunChleoc (gunchleoc) on 2016-10-10
tags: added: graphics
removed: graphic
GunChleoc (gunchleoc) on 2017-02-26
Changed in widelands:
status: Incomplete → In Progress
assignee: Jens Beyer (qcumber-some) → GunChleoc (gunchleoc)
GunChleoc (gunchleoc) on 2017-05-03
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers