x\y axis in ware statistics are wrong

Bug #976077 reported by mr.x on 2012-04-07
This bug affects 3 people
Affects Status Importance Assigned to Milestone

Bug Description

X\y are "reversed"

x axis counts time downwards and the graph is increasing

y axis count correct but is showing on the right side (this could be a feature, and not a bug)

Related branches

mr.x (borgensteinar) wrote :

both general and ware statistic graphs are like this

SirVer (sirver) wrote :

What exactly do you think is wrong? Could you provide a screenshot?

affects: widelands-media → widelands
Changed in widelands:
status: New → Incomplete
mr.x (borgensteinar) wrote :

Y axis on the right side of graph

x axis counting time "backwards"

mr.x (borgensteinar) wrote :

either the whole x\y axis drawing function is swapped somewhere, or the x axis counting starts at the wrong end

SirVer (sirver) wrote :

Why? The zero point is now and time is counted backwards. The x axis continues in definitively to the left. I see nothing wrong.

mr.x (borgensteinar) wrote :

I am clearly only talking for myself here.
Right now theres no indication that we are counting backwards, so when i se a grapf moving to the right and then i see numbering to the left, i get confused.
If a "-" is added, i can follow you. But even then it is because most, if not all, Graphs that you encounter are made from the left counting to the right. (yes there are some negative graphs, but most of them have a couple of positive numbers for reference)

Althoug the graph is not technicly "wrong" (if a "-" is added), i think it would look more "right" if it got changed.

either way its a low priority thing, do with it as you please

_aD (ad-simplypeachy) wrote :

The fact that the slider's "time" goes in the opposite direction to the graph's is inconsistent. I knew there was some reason the graphs never made sense to me - I was reading them the other way around! I always thought that time moved to the right when showing graphs.

SirVer (sirver) wrote :

What would you all suggest? Adding a 'minus' in front of the time numbers? Or changing the slider?

Chuck Wilder (chuckw20) wrote :

+1 for reversing the slider. To me, the graph is very intuitive, showing the old data marching into history. :) So reversing the slider would would make it more consistent, i.e. to show more history, one would move the slider "back" along the time line.

Angelo Locritani (alocritani) wrote :

+1 for adding a 'minus' in front of time numbers.Data displayed at 15 is indeed related to 15 minutes ago

wl-zocker (wl-zocker) wrote :

+1 for adding a "minus". Both the graph and the slider are intuitive to me.

Hans Joachim Desserud (hjd) wrote :

Most people seem to agree this should be changed.

Personally, it has always made sense to me that the graph displays the progress up untill this point (and what happened x minutes ago). Then again, I played the settlers2 demo back in the day.

I think adding minus (-) to the times would clearify that we are viewing the upper-left quadrant of a cartesian plane/coordinate system. (In other words, quadrant II here http://en.wikipedia.org/wiki/File:Cartesian_coordinates_2D.svg)

I am not convinced about reversing the slider though, as that is (to some extent) displaying something different. The slider is for selecting the range to view, which naturally goes from the smallest to the largest range. So further right means a larger slice of time displayed. This is consistent with other plus/minus buttons in the game which also use the right side for increasing. I see the point of people who wish to change it though, but I wonder if that might be even more confusing.

We could also consider adding some labels, like "time ago" for X and "count" for Y. Rather poor suggestions, but something along those lines. I am not sure how or where to place these where they aren't awkward or too overlapping.

My suggested compromise: add minus to the x axis, then decide whether we want to experiment with flipping the slider as well.

Changed in widelands:
importance: Undecided → Low
status: Incomplete → Confirmed
tags: added: statistics ui
Joachim Breitner (nomeata) wrote :

Minus added and improved spacing a bit; see the linked branch.

SirVer (sirver) wrote :

Thanks joachim. I set to fix committed for now, if someone is not happy with the new status quo, please speak up again and we reopen.

Changed in widelands:
status: Confirmed → Opinion
status: Opinion → Fix Committed
Changed in widelands:
milestone: none → build18-rc1
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments