possible bug in void BulldozeConfirm::think()

[David Allwicher]

src/wui/bulldozeconfirm:112

There is some rather strange code fragment:

        and (1 << Widelands::Building::PCap_Bulldoze)
<=> and (1 << 0)
<=> and (true)

maybe someone can explain this to me?

[David Allwicher (aber)]

nha? :)

[Nicolai Hähnle (nha)]

Should be bitwise and obviously, i.e. &. Some overzealous anti-& person replaced it incorrectly.

For the record, I oppose the use of the not, or, and and keywords (preferring !, ||, and &&), because the vast majority of the C++ using world sees it as more idiomatic.

[SirVer (sirver)]

>For the record, I oppose the use of the not, or, and and keywords
>(preferring !, ||, and &&), because the vast majority of the C++ using
>world sees it as more idiomatic.

Just to state another opinion: I personally find them easier to read and
the C++ community is notably slow to adapt new features in their
language, so I do not worry about this too much.
I agree that it is usually not worth replacing the && || and ! though,
for new code I feel everybody should suit his/herself.

  status triaged
  importance medium

[David Allwicher (aber)]

Sorry, I had not enough time to open my eyes an look properly. I was kinda confused, why someone would shift by zero.

[Hans Joachim Desserud (hjd)]

Could you please elaborate why this was set to invalid? :)

[Nasenbaer (nasenbaer)]

Oh sorry, my fault... I must somehow mixed things up here... :)

[SirVer (sirver)]

Released in build17-rc1.