Patch - Changes to spinboxes' behaviour

Bug #896879 reported by Angelo Locritani on 2011-11-27
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Undecided
Unassigned

Bug Description

I've created three patches:

[switch_buttons.patch]
In options windows, I think the plus and minus signs should be inverted.
Usually is common to have minus on left side, and plus on the right

[change_button_enable_logic.patch]
I think that the --/++ buttons should alway be active and if adding/removing 10 brings the value over/under the minimum/maximum, the value should stick to the limits. They will work like a fast-forward options.

[add_replacement_for_remove_replays.patch]
Replaced "0 days" for replays with "never". Sorry, but no idea if other than adding the value I have to set the word to be translatable somewhere.

Just a question: is correct to add patches like bugs or should I post them on forums?

Tags: ui Edit Tag help

Related branches

Angelo Locritani (alocritani) wrote :
David Allwicher (aber) wrote :

hey Angelo,

Contributions is always highly welcome! But adding patches to the bug-tracker or the forum has some major drawbacks. It is way easier to see what you did and to apply your changes, if you upload them to a branch on launchpad. Then you can add a merge request and someone can have a look and give you feedback or merge your changes to trunk.

We have a wikipage trying to describe how you use bzr :)
http://wl.widelands.org/wiki/BzrPrimer/

Hans Joachim Desserud (hjd) wrote :

Hi, and thanks for your suggestions. The preferred workflow is to create a branch, push it to launchpad, and then create a merge request from the branchpage. This will show a colored diff of your changes and allow people to post comments on the review. In this case you might push the patches to different branches to keep them separated, as they seem to deal with different issues.

See https://help.launchpad.net/YourAccount/CreatingAnSSHKeyPair and https://help.launchpad.net/Code/UploadingABranch for how to do this.

tags: added: ui
Angelo Locritani (alocritani) wrote :

thanks aber, thank hjd, I will now read the suggested link and try to create one branch for every patch.

Angelo Locritani (alocritani) wrote :

Hi people, I tried. I put all my goodwillness but found that this bzr is really slow (at least for me - 20 mins just to branch). Also at moment my pc is almost full, so I found difficult to create a new branch.
I prefer git, but I know this topic has already been discussed in the past - just my personal opinion...

Anyway, I will be very happy if you can apply the patches without going through the preferred workflow...

Jens Beyer (qcumber-some) wrote :

I've added and linked three branches for Review/Merge on behalf of alocritani

Tino (tino79) wrote :

I've tested all 3 branches and fully support merging this.
This makes the option window more consistent, i never liked the + left/ - right

David Allwicher (aber) on 2011-11-28
Changed in widelands:
status: New → Fix Committed
milestone: none → build17-rc1
SirVer (sirver) wrote :

Angelo, I added you to the lists of developers in r6146. please have a look if the line suits you like that:
http://wl.widelands.org/developers/ (will appear there in < 24h)

Angelo Locritani (alocritani) wrote :

I was not expecting that (I did just a very small change) so thanks!

SirVer (sirver) wrote :

Contribution is contribution and where else should we draw the line :).

SirVer (sirver) wrote :

Released in build17-rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers