Player and category buttons in the general statistics window
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Low
|
Unassigned |
Bug Description
(Split out from bug 536543)
When the slider was added to the general statistics window, there was also some other changes to it. Previously the player buttons would fit to width based on how many players were in the game, and also the categories took more space. This is a bit repetition of what was mentioned on the other bug, and on IRC, but I'll try to list the argument for both approaches.
Current:
*All buttons consistently have the same size across all games.
*Players always know where the buttons will be and it is faster to switch players on and off, since the distance is shorter.
Previous:
* The current solution leaves a lot of unused space in the window, especially considering games with few players. The previous window adjusted the width of player buttons to always fill the entire row. The window looks like it takes up more space, than the previous solution which filled out and used the assigned area.
* Though the player buttons will not always have the same size from game to game, they will appear consistently in the same order. The player buttons in a single game will all have the same size though, but a game the player plays later may have different width if the number of players is different. (Personally I see this as a minor issue, as a player will only play one game at a time and the buttons will adjust according to the same system each time).
Presonally, I really liked how the players' width adjusted based on how many players were involved, so that no matter they would fill up the entire row. Now when you play a game with only a few players, a lot of the space on the right side is left blank. Though I am obviously quite biased, so what do others think?
Related branches
- Widelands Developers: Pending requested
-
Diff: 11 lines (+1/-0)1 file modifiedsrc/ui_basic/box.cc (+1/-0)
Just a remark about the window width: The current width is quite arbitrary; I had put some value in and did not change it later. So this is a related, but partly independent issue: Should the window be just as wide as necessary (probably the width of the second row of buttons) or wider? If wider, what is a proper width? Should both statistics windows have the same width?
Otherwise, this issue is a matter of taste, and has no clear right or wrong solution. So we need many opinions to find a consensus. Please comment ahead :-)