Buildings taken over by enemies no longer show flags with player color

[Hans Joachim Desserud]

Player A builds a military building. Once the building is occupied it will show flags in the player color to display who owns it and that it is occupied. However, if A player B takes over this building the flags are no longer shown.

I noticed this earlier today, when a player had taken over some buildings and I was sure there were soldiers in them even if they had no flags. Then I saw that in one place the player had two identical buildings next to each other, and while one of them had flags the other didn't. Turned out that the second building had been taken over from another player.

Even if player A reclaim the building, the flags does not show. I wonder if someone should look into how the flags are handled when a building change owner.

I've attached an example screenshot.

Widelands r6078

[SirVer (sirver)]

i expect this to be a problem with the barrier only, or does this affect every military building?

[Hans Joachim Desserud (hjd)]

As far as I can see, this affect all military buildings. It was especially clear with two barbarian forts next to each other, one conquered and one built. (I don't have a screenshot of this unfortunately.)

[SirVer (sirver)]

I could not reproduce this. I was atlanteiden and took over buildings from a barbarian. And the flags where showing on the buildings i conquered.

[SirVer (sirver)]

I correct myself. After the buildings have been *reconquered* by a third barbarian, they indeed did not show any flags

[Shevonar (shevonar)]

Conquered buildings showed the unoccupied animation instead of the idle animation.

Fixed in revision 6251

[SirVer (sirver)]

Released in build17-rc1.