Show census information as long as fires burn

[Astuur]

This is again a suggestion to improve the gameplay.
It often happens that after borders have moved from conquering some building,
I am no longer sure which enemy buildings are currently burning down -- sometimes
I am not even sure which ones of my building I have lost.
To put the burning phase of the buildings to some use, it may be helpful to still show the census information
while those building burn. (for both, the players own buildings and enemy ones)
This helps for tactical considerations when attacking, but also to better find countermeasures for own losses.
The color of the font should probably change in this case, since yellow is not visible well inside the flames.

[Nasenbaer (nasenbaer)]

I like the idea. Anyone up for a design concept for the colors?

[Astuur (wolfsteinmetz)]

On a second look, it seems there is no need for a displacement or color shift.
There is only one fire animation for all buildings, and the position of the census is usually higher than the flames
reach. So we could leave the census "as is" and "where it is", but continue showing it during the
burning phase.
The flattest building seems to be the imperial well, and even that look okay.

[SirVer (sirver)]

Note that this is an non-trivial coding change: currently, immovables (like fire) do not have a history in their data; therefore some change is required there. Also, load and save code is required for those things. I am not against this change but it is defenitivly nothing for a complete newcomer to the code.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Astuur (wolfsteinmetz)]

In addition it may even be helpful to have a message like
"You have just lost your warmill" sent to the messages window.
Only for your own losses, of course.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]

[SirVer (sirver)]

This might also clash with the zoom branch :/. Maybe we can lift feature freeze from trunk earlier and cherry pick bug fixes into b19 branch.

> Am 23.10.2016 um 15:50 schrieb GunChleoc <email address hidden>:
>
> ** Branch linked: lp:~widelands-dev/widelands/bug-863185-census-on-
> destroyed-building
>
> ** Changed in: widelands
> Status: Confirmed => In Progress
>
> ** Changed in: widelands
> Assignee: (unassigned) => GunChleoc (gunchleoc)
>
> ** Changed in: widelands
> Milestone: None => build20-rc1
>
> --
> You received this bug notification because you are subscribed to
> widelands.
> https://bugs.launchpad.net/bugs/863185
>
> Title:
> Show census information as long as fires burn
>
> Status in widelands:
> In Progress
>
> Bug description:
> This is again a suggestion to improve the gameplay.
> It often happens that after borders have moved from conquering some building,
> I am no longer sure which enemy buildings are currently burning down -- sometimes
> I am not even sure which ones of my building I have lost.
> To put the burning phase of the buildings to some use, it may be helpful to still show the census information
> while those building burn. (for both, the players own buildings and enemy ones)
> This helps for tactical considerations when attacking, but also to better find countermeasures for own losses.
> The color of the font should probably change in this case, since yellow is not visible well inside the flames.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/widelands/+bug/863185/+subscriptions

[GunChleoc (gunchleoc)]

With the amount of branches waiting, we are bound to have some clashes. I also shifted the census/statistics stuff in another branch, so we already have 3 co0nflicting branches for this.

So, +1 for lifting freeze from trunk as soon as we have split off b19-rc1.

[GunChleoc (gunchleoc)]

Found the branch where I did the statistics/census stuff:

http://bazaar.launchpad.net/~widelands-dev/widelands/map_objects_without_wui/revision/8128

[GunChleoc (gunchleoc)]

Fixed in build20-rc1