Increase maximum number of terrain types

Bug #821553 reported by Chuck Wilder
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Wishlist
Unassigned

Bug Description

Current code supports a maximum of 16 terrain types per world. Refer to http://wl.widelands.org/forum/post/233/ and more recently http://wl.widelands.org/forum/post/5557/
A larger number is desirable to increase the graphic variety that could be achieved in the maps given the availability of more terrain types such as multiple water graphics to differentiate between inland lake, river and ocean water or other new and possibly animated terrain.

Revision history for this message
Chuck Wilder (chuckw20) wrote :

A question: Would increasing the number of terrain types have an impact on the use of S2 maps as long as the order of the first 16 types was maintained? And is even that necessary?

Changed in widelands-media:
importance: Undecided → Wishlist
Chuck Wilder (chuckw20)
tags: added: editor graphic
Chuck Wilder (chuckw20)
description: updated
Revision history for this message
SirVer (sirver) wrote :

I am currently unable to answer the question :(. Need to look at the code.

Regards,
Holger

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Marking this confirmed, since multiple people would like to see this. (Lastly http://wl.widelands.org/forum/topic/1105/?page=1#post-8647)

Changed in widelands:
status: New → Confirmed
Changed in widelands-media:
status: New → Confirmed
Revision history for this message
SirVer (sirver) wrote :

Seems like a good idea to just merge the worlds into one big one and be a little more clever about what gets loaded and when.

Revision history for this message
Nicolai Hähnle (nha) wrote :

See also wish / bug #951554 (Impassable water), which depends on having more terrain types.

Revision history for this message
Frank Pieper (frank-pieper-1) wrote :

I advise to take Attributes for "artifistic Impassable" (and any other Attributes) but I won't call it impassable Water but DeepWater resp unwadable as if you can swim I don't see a Reason to wall Swimmers (eg Ducks ;).
Attributes for Passing_Matters throw Logic on a Problem which is arithmetic (geometric). Both Ant and Ship can't pass if they can't deal with a Deep of WaterTerrain while a Horse can wade through. We can beat the Problem dead with Logic (Pass-Flags) but we deal here with an geometric Matter and should prefer Aritmethic. For GameMatters like Campaign ("you still can't walk this way..", blocking Fog, etc) we may prefer the Flags but for physical Matters (in particular Geometry - Metry of Geo) we may prefer Numbers. Bread or Butter, what we will take?

SirVer (sirver)
Changed in widelands:
status: Confirmed → In Progress
no longer affects: widelands-media
Changed in widelands:
milestone: none → build19-rc1
assignee: nobody → SirVer (sirver)
Revision history for this message
Astuur (wolfsteinmetz) wrote :

Got me all exited with that bit of news, SirVer :)
It will not be an "unlimited" number of different terrains, I suppose.
How many, if you really want to merge all "words"?

Revision history for this message
SirVer (sirver) wrote :

There is no arbitrarty limit on the number of terrains that can be defined in a world in the branch. Also, as long as you do not rename a terrains name, all old and new maps should stay compatible. Right now there are ~60 terrains defined (64 from all worlds, but there were some duplicates like lava and some water terrains), but nothing stops you from defining another 60. :)

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Based on the previous comment, now that one_world has been merged, this has been fixed?

SirVer (sirver)
Changed in widelands:
status: In Progress → Fix Committed
assignee: SirVer (sirver) → nobody
GunChleoc (gunchleoc)
tags: added: graphics
removed: graphic
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers