widelands

Two sentences in game tips are only partly translatable

Bug #738888 reported by Hans Joachim Desserud on 2011-03-20

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	widelands	Fix Released	Medium	Unassigned	widelands build17-rc1

Bug Description

While browsing translations I noticed two odd strings:
https://translations.launchpad.net/widelands/trunk/+pots/texts/nb/3/+translate and https://translations.launchpad.net/widelands/trunk/+pots/texts/nb/101/+translate . I checked the textfile they came from, and it turns out only parts of the sentences are picked up and made translatable. I assume the reason is the sentences include more than one ' and that symbol is interpreted as the start and stop of the string. I saw another string like it was wrapped in quotation marks ("), so I did that here as well. I then ran utils/buildcat.py to see if the new .pot-files got the entire string and they did. So I pushed my changes to the tips, and I'll attach the branch.

Tags:

Related branches

lp:~hjd/widelands/fix-partly-translatable-sentences

Rejected for merging into lp:widelands

SirVer: Disapprove on 2011-03-21

lp:~shevonar/widelands/fix-partly-translatable-sentences (Merged)

Hans Joachim Desserud (hjd) on 2011-03-20

tags:	added: internationalization
Changed in widelands:
importance:	Undecided → Low

Revision history for this message

SirVer (sirver) wrote on 2011-03-21:

Very good find! The real bug is likely in the python script we use to parse the conf files though and I prefer fixing it to changing the conf files. I will have a look at this after build 16.

Changed in widelands:
status:	New → Confirmed
importance:	Low → Medium
milestone:	none → build17-rc1
assignee:	nobody → SirVer (sirver)

Revision history for this message

Shevonar (shevonar) wrote on 2011-09-12:

fix-partly-translatable-sentences.diff Edit (1.9 KiB, text/plain)

Since I'm new and looking for small things I can do, I tried to fix the python script. I hope it's okay for you that I'm stealing "your" bugs SirVer.
This fix will fix the strings mentioned here, but I'm not sure if it will cause problems on other strings. I also added some missing periods in the game tips.

Revision history for this message

Shevonar (shevonar) wrote on 2011-09-12:

Added branch for my fix.

Changed in widelands:
status:	Confirmed → In Progress

Revision history for this message

SirVer (sirver) wrote on 2011-09-14:

No problem at all taking my bugs. :) I am not entirely sure if this breaks other things, but since there are no tests around for that, I can only assume the best.

If you want to do more Shevonar, you can add tests for the conf files similar to the test_luxgettext.py script and improve the confgettext script which is no beast of beauty. Thanks for this fix however!