Pause game while in 'save'-dialog

Bug #738643 reported by LAZA on 2011-03-20
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Wishlist
cghislai

Bug Description

it would be much comfortable if the game is automatically paused when the player wants to save it.
in the tutorial often messages and dialogs pops up while i'm in the save dialog and this is annoying and confusing (especially for Newbies)
for me normally playing in 2x speed to much happens in this time, - and still forget to pause before i save...

Tags: ui Edit Tag help

Related branches

Changed in widelands:
importance: Undecided → Wishlist
summary: - pause game while in 'save'-dialog + message when saving --> wishlist
+ pause game while in 'save'-dialog + message when saving

I fully agree with providing some feedback during autosaving. I actually noticed this yesterday and planned to report it, but you beat me to it. :)
I thought about using the chat system or something similar to print some feedback, like "Autosaving..." when it starts, and "Saved" when it is finished. That way, the user will know what the game is doing, while today the game only seems to freeze when the autosave happens, especially on large maps.

When it comes to the save game dialog, I'm a bit unsure since no other dialogs will pause the game. Though I guess it could make sense if the game is paused when bringing up the save game dialog, to better provide time to type in a name for the savegame. I also think the game should be unpaused when the dialog is closed, so you can return to the game instantly. It also needs to handle if the user manually paused the game, though.

Final thought: this bug seems to cover two separate issues to me. Should the part with autosave be split out perhaps?

LAZA (laza74) wrote :

In fact, these are two 'bugs' - if you want so.

But for me it makes sense, to implement both at once but i'm no hacker/programer and so it is the decision of those, who where assigned to do it...
So you (and all those other which where notified) are nearer to the project and shurely know more about this issue so i let the decision those who are in command ;-)

SirVer (sirver) wrote :

please make these two bug reports

Hans Joachim Desserud (hjd) wrote :

I have split out "show message when autosaving" to bug 738895.

summary: - pause game while in 'save'-dialog + message when saving
+ Pause game while in 'save'-dialog
tags: added: ui
description: updated
LAZA (laza74) wrote :

Thanks Hans!

Gabriel Margiani (gamag) wrote :

In multiplayer games it would look very strange to other players if the game pauses for a short time and than continues, because they don't know that one player was in the save dialog...
So I think the dialog should only pause a sigleplayer game.

Changed in widelands:
status: New → In Progress
assignee: nobody → cghislai (charlyghislain)
SirVer (sirver) wrote :

Dont Pause when the window is open but pause when the game is actually saving. Pausing when the window is open would be very different to how all menus in wl work.

cghislai (charlyghislain) wrote :

Pausing when the game is saving is already done as the save logic is inside the game loop, if im not mistaken. The issue raised in the first post is that things may happen in the background when you try to save (when youre in the save dialog) and it may be annoying especially with scripted games.

Should I revert that commit and mark this bug as won't fix?

SirVer (sirver) wrote :

No, obviously this approach didn't seem strange to you as it did to me. So maybe it actually feels natural. Let's try it out and see what happens with t.

Hans Joachim Desserud (hjd) wrote :

Works like a charm, even in multiplayer. Thanks :)

Changed in widelands:
milestone: none → build18-rc1
status: In Progress → Fix Committed
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers