widelands

Add evict worker button to productionsites

Bug #714036 reported by Nasenbaer
52
This bug affects 10 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Wishlist
Gabriel Margiani
widelands build18-rc1

Bug Description

As described in bug #536149 there are some circumstances that lead to situations, where experienced workers are not needed in a building (and could be replaced), but are needed in another building. Therefor an "evict worker" button would help.

Related branches

lp:~victor-pelt/widelands/workers
Rejected for merging into lp:widelands
Nasenbaer: Needs Fixing
Nicolai Hähnle: Needs Fixing
SirVer: Needs Fixing
Diff: 1057 lines (+544/-42)
23 files modified
src/logic/building.cc (+26/-1)
src/logic/building.h (+4/-0)
src/logic/constructionsite.cc (+23/-0)
src/logic/constructionsite.h (+2/-0)
src/logic/game.cc (+7/-0)
src/logic/game.h (+1/-0)
src/logic/immovable.cc (+1/-0)
src/logic/militarysite.cc (+15/-0)
src/logic/militarysite.h (+2/-0)
src/logic/player.cc (+21/-0)
src/logic/player.h (+1/-0)
src/logic/playercommand.cc (+60/-1)
src/logic/playercommand.h (+24/-0)
src/logic/production_program.cc (+8/-8)
src/logic/production_program.h (+4/-1)
src/logic/productionsite.cc (+69/-24)
src/logic/productionsite.h (+9/-2)
src/map_io/widelands_map_buildingdata_data_packet.cc (+4/-4)
src/wui/buildingwindow.cc (+28/-1)
src/wui/buildingwindow.h (+1/-0)
src/wui/evictconfirm.cc (+180/-0)
src/wui/evictconfirm.h (+35/-0)
tribes/barbarians/conf (+19/-0)
lp:~gamag/widelands/SimpleEvictWorkerButton
SirVer: Approve
Diff: 1236 lines (+293/-165)
11 files modified
src/logic/game.cc (+7/-0)
src/logic/game.h (+1/-0)
src/logic/instances.h (+2/-2)
src/logic/playercommand.cc (+164/-105)
src/logic/playercommand.h (+59/-35)
src/logic/productionsite.cc (+20/-15)
src/logic/queue_cmd_ids.h (+2/-0)
src/logic/tribe.h (+4/-4)
src/rect.h (+2/-2)
src/wui/productionsitewindow.cc (+30/-2)
src/wui/productionsitewindow.h (+2/-0)
lp:~aber/widelands/jetAnotherEvictButton
Revision history for this message
SirVer (sirver) wrote :

Well -- one of our oldtimer bugs. Will not be in build 17 I guess - too big a change.

Changed in widelands:
milestone: build17-rc1 → none
Revision history for this message
Xiong (xiong-mochamail) wrote :

Endorse this feature. Relief from micromanagement should not mean inability to manage at all.

Here's another use case: I have a master miner all trained up in an iron mine but the coal miner is less experienced. Both mines are exhausted but I need coal *now*. I'll need iron later -- badly enough to deepen the iron mine -- but for now I just want to deepen the coal mine and reassign the master.

Revision history for this message
Gabriel Margiani (gamag) wrote :

Merged in r6500.

Changed in widelands:
status: Confirmed → Fix Committed
assignee: nobody → Gabriel Margiani (gamag)
milestone: none → build18-rc1
Revision history for this message
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.