map location markers not stored in save game

[Marty Shannon]

the new map location markers (control-digit to set; digit to goto) don't get saved in the save game. this is troublesome when playing a long-term, many session game (think 2 players on a 512x512 map). Please save and restore these.

[Hans Joachim Desserud (hjd)]

This problem is reproducible in bzr rev. 5429 on Ubuntu 10.04.

[Hans Joachim Desserud (hjd)]

With the transition from pluto to eris, we will be breaking backwards compatibility for savegames anyways, so we might want to consider wether we want to add this information to the save game format.

[SirVer (sirver)]

this is orthogonal: We can easily add this information right now in a backwards compatible way, this will not break anything.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Klaus Halfmann (klaus-halfmann)]

Oh, this is not working on OSX with e.g. bzr8081[bug-1618547-wares-queue-order].
Where ins an (unzipped) save file should I find this?

can somone confirm this?

[GunChleoc (gunchleoc)]

binary/interactive_player

That's a binary packet though.

[kaputtnik (franku)]

Different behavior here:

Tested a normal game and location markers get rembered when exiting widelands and reload the savegame again.

Test the Seafearing tutorial and the location markers does not survive the save/reload. Instead the map get moved to different loacations, but not the ones i defined before.

Klaus, which map do playing?

[Klaus Halfmann (klaus-halfmann)]

Currently I play "Twin Lagoons" as Atlanter,
but this never ever worked for me. Will check the interactive_player file now ...

[Klaus Halfmann (klaus-halfmann)]

Here is my interactive_player file, quite small

and here the logs from saving the map:

Game: Writing Preload Data ... took 14ms
Game: Writing Game Class Data ... took 0ms
Game: Writing Player Info ... took 137ms
Game: Writing Map Data!
Writing Elemental Data ... took 5ms
 Writing Player Names And Tribe Data ... took 0ms
 Writing Port Spaces Data ... took 1ms
 Writing Heights Data ... took 9ms
 Writing Terrain Data ... took 14ms
 Writing Player Start Position Data ... took 0ms
 Writing Player Message Data ... took 9ms
 Writing Resources Data ... took 17ms
 Writing Map Version ... took 0ms
 Writing Allowed Worker Types Data ... took 0ms
 Writing Allowed Building Types Data ... took 1ms
 Writing Flag Data ... took 10ms
 Writing Road Data ... took 2ms
 Writing Building Data ... took 5ms
 Writing Map Objects ... Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! Tribe immovable has no owner!! took 91ms
 Writing Flagdata Data ... took 5ms
 Writing Roaddata Data ... took 29ms
 Writing Buildingdata Data ... took 25ms
 Writing Node Ownership Data ... took 5ms
 Writing Exploration Data ... took 11ms
 Writing Players Unseen Data ... took 56ms
 Writing Scripting Data ... took 391ms
 Writing Objective Data ... took 0ms
 Writing map images ... took 1ms
 MapSaver::save() for 'Twin Lagoons' took 698ms
Game: Writing Map Data took 699ms
Game: Writing Player Economies Info ... took 4ms
Game: Writing ai persistent data ... took 0ms
Game: Writing Command Queue Data ... took 155ms
Game: Writing Interactive Player Data ... took 0ms
GameSaver::save() took 1010ms
SaveHandler::save_game() took 1010ms

[kaputtnik (franku)]

I couldn't reproduce this, sorry. Could you attache your savegame here?

[Marty Shannon (mjshannon3)]

Check the original filing date. I don't even have the computer it occurred
on anymore. Easy to reproduce, if it's still broken:

1. set all 10 map markers to different sections of the map, and verify they
work;
2. save game & exit;
3. resume game, and cycle through all 10 map markers you set in step 1;
4. if you don't move to each map marker in step 3, it's still broken.

--Marty

On Sat, Sep 3, 2016 at 12:52 PM, kaputtnik <email address hidden>
wrote:

> I couldn't reproduce this, sorry. Could you attache your savegame here?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/601398
>
> Title:
> map location markers not stored in save game
>
> Status in widelands:
> Fix Committed
>
> Bug description:
> the new map location markers (control-digit to set; digit to goto)
> don't get saved in the save game. this is troublesome when playing a
> long-term, many session game (think 2 players on a 512x512 map).
> Please save and restore these.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/widelands/+bug/601398/+subscriptions
>

[GunChleoc (gunchleoc)]

I just tested with the Seafaring tutorial and it works. So, scripting being present is not the problem.

For debugging, you could try adding some log output to the read and write functions of the packet - see the merge request attached to this bug on where the code is.

[Klaus Halfmann (klaus-halfmann)]

OK I added some debugging code and found:

Writing 10 landmarks
landmark set 1 at 4015,2020
landmark set 1 at 3235,2020
landmark set 1 at 559,2020

Reading 10 landmarks
landmark set 1 at 4015,2020
landmark set 1 at 3235,2020
landmark set 1 at 559,2020

all fine, for a local game, but for a networking game I got

Writing 10 landmarks
landmark set 1 at 910,1207
landmark set 1 at 540,840
landmark set 1 at 1780,1207
...
Reading 10 landmarks
landmark set 0 at 0,0
landmark set 0 at 0,0
landmark set 0 at 0,0
landmark set 0 at 0,0

So for networking games the save/load structure seems different

[GunChleoc (gunchleoc)]

I have found the source of the problem and opened a new bug for it:

https://bugs.launchpad.net/widelands/+bug/1623375

The packet containing the information isn't read in multiplayer mode at all - this affects the viewpoint as well.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.