Rev 5335 breakes linking on win32/mingw

Bug #580377 reported by Tino on 2010-05-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
High
Nicolai Hähnle

Bug Description

5333 and 5334 are fine, something changed with 5335. Talked to a few other guys on irc yesterday, this errror seems only to exist on windows.
Make clean and/or calling cmake again don't help.

Output
======

user@HOST /h/wl_build
$ make
-- Version of Widelands Build is bzr5335[widelands](RELEASE)
[ 0%] Built target BzrRevision
[ 0%] Built target lang_dummy
[ 6%] Built target widelands_editor_ui_menus
[ 15%] Built target widelands_main
[ 16%] Built target widelands_ai
[ 20%] Built target widelands_economy
[ 23%] Built target widelands_game_io
[ 26%] Built target widelands_graphic
[ 27%] Built target widelands_io
[ 28%] Built target widelands_io_filesystem
[ 45%] Built target widelands_logic
[ 56%] Built target widelands_map_io
[ 57%] Built target widelands_network
[ 58%] Built target widelands_profile
[ 62%] Built target widelands_scripting
[ 63%] Built target widelands_sound
[ 71%] Built target widelands_ui_basic
[ 77%] Built target widelands_ui_fsmenu
[ 93%] Built target widelands_wui
[ 93%] Built target widelands_editor
[ 99%] Built target widelands_editor_tools
Linking CXX executable widelands.exe
Creating library file: libwidelands.dll.a
logic/libwidelands_logic.a(editor_game_base.cc.obj):editor_game_base.cc:(.text+0xa79): undefined reference to `Widelands
::Player::rediscover_node(Widelands::Map const&, Widelands::Field const&, Widelands::FCoords)'
collect2: ld returned 1 exit status
make[2]: *** [src/widelands.exe] Error 1
make[1]: *** [src/CMakeFiles/widelands.dir/all] Error 2
make: *** [all] Error 2

user@HOST /h/wl_build
$

Tino (tino79) on 2010-05-14
summary: - Rev 5335 brakes linking on win32/mingw
+ Rev 5335 breakes linking on win32/mingw
Jens Beyer (qcumber-some) wrote :

I was one of those on IRC who said it would not break.
I revert that statement. Rev. 5335 breaks on Linux too.

It breaks if you do a Release build. It doesn't break if you do a Debug build.

SirVer (sirver) wrote :

This puzzles me. I only renamed "discover_node" to "rediscover_node" and made it public. Maybe make screwed up; try to wipe your build directory (not only make clean, it failed me in the past) and rebuild.

Changed in widelands:
status: New → Confirmed
importance: Undecided → High
Nicolai Hähnle (nha) wrote :

Should be fixed in r5337

Changed in widelands:
assignee: nobody → Nicolai Hähnle (nha)
status: Confirmed → Fix Committed
SirVer (sirver) wrote :

Released in build16-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers