Make the RMB optional for playing widelands

Bug #579830 reported by Tomasz Sterna
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Wishlist
Unassigned

Bug Description

Widelands interface uses right mouse button a lot. This is not feasible on touch screen devices (like Nokia Internet Tablets).

The attached patch changes the interface the following way:
- drag map with LMB
- use 5px drag threshold to register small drags as clicks
- double-click LMB on window frame and background to close windows
- single-click on icon grid highlights the button and shows description
- double-click on icon grid activates the button

Revision history for this message
Tomasz Sterna (smoku) wrote :
Revision history for this message
SirVer (sirver) wrote :

Thanks for the report and your patch. However, the current interface works well for the mouse (and therefore for PCs). I see that other ways to control widelands are desirable for other devices, but changing the working interface for all devices because some do not support it seems rather radical.

I suggest reworking this patch into a feature that can be toggled via a option and keep the old behavior the default. A feature branch on widelands that implemented this would be most welcome.

Are you interested in tackling this Tomasz?

Ps: I reworded the bug description into this direction.

Changed in widelands:
status: New → Triaged
importance: Undecided → Wishlist
summary: - [PATCH] Do not use RMB with touch screen
+ Make the RMB optional for playing widelands
Revision history for this message
Tomasz Sterna (smoku) wrote :

Yup. I certainly understand your points.
My submition to Launchpad wasn't for integrating these changes, but rather for sharing and making it available for wider audience (other devices users might be interested). This was quickly hacked in, while porting Widelands for Nokia N900.

I will see into reworking it to a feature.
Compile-time toggle, or UI checkbox one?

Revision history for this message
Raul Ferriz (raul.ferriz) wrote :

Preferable checkbox one. So can be togled at runtime.

Many thanks!

Revision history for this message
Nicolai Hähnle (nha) wrote :

Since, as you said, this should be useful for other similar devices, I'm in favor of trying to merge such changes into trunk. It would be annoying to have a situation where a dozen patches are flying around without a clear direction (of course, bzr branches would make that somewhat more bearable, but if it can be integrated into trunk as a toggleable option, I think that's the way it should be done).

Revision history for this message
SirVer (sirver) wrote :

Nicolai, that was my intention. That's why I asked to have it toggable. I also suggest merging Tomasz work then. I just meant that having a branch on launchpad would make collaboration easier then patches, I should have phrased this more clearly.

Revision history for this message
Mark Scott (mxsscott) wrote :

This helps Macs as well. Widelands is awkward to play on a Macbook with a touchpad with single button.

Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Triaged → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
SirVer (sirver)
Changed in widelands:
status: Expired → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.