Pack animals overlay carriers when both are idle

[Chuck Wilder]

Currently when both are idle, the animations for pack animals and carriers who share the same segment of road overlay one another. This can yield some rather peculiar visual results.

Please separate the resting spots for these two workers.

[SirVer (sirver)]

this is not trivial, as bobs always reside on fields and a road of length 2 has only one central field. Some non trivial code changes will be necessary for this.

[Nicolai Hähnle (nha)]

I don't know if it's worth doing for length-two roads; however, for longer roads we can do it. On odd-length roads it actually makes a lot of sense. We could even let the logic be to have carriers rest one field away from the flag that terminates the road when two carriers are present. It would be a reasonable thing to do if you had such a road system in real life.

[SirVer (sirver)]

but length-two roads are the norm and length-three roads are normally the longest I have. If this disturbs the graphicians, a solution for length-two roads must be found.

[Hans Joachim Desserud (hjd)]

As the pack animal is usually the largest, I thought it perhaps would help to always put the carrier in front of the animal. The strangest results I see is when the animal is covering the person to the point where you can only see the legs. I don't know how this is done in the code, but if there is a certain order for drawing workers this could be reorganized. Then the animal could be drawn first and the carrier on top, which would look less overlapping.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[wl-zocker (wl-zocker)]

This still happens in r6970 and looks quite odd. As suggested in #4, drawing the carrier onto the animal would probably look much better. For length-three roads (and longer ones) we can additionally but the carrier and the animal on different fields as suggested in #2, if this is not too complicated (code-wise). This would maybe even help the AI a bit which tends to build mor length-three roads than human players.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]

[GunChleoc (gunchleoc)]

Migrated to https://github.com/widelands/widelands/issues/1213