widelands

localedir adjustement

Bug #572384 reported by Pavol Rusnak on 2010-04-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	widelands	Won't Fix	Medium	Unassigned

Bug Description

This patch makes it much easier to build on Linux. Fixes probably some relic code ...

Revision history for this message

Pavol Rusnak (prusnak) wrote on 2010-04-30:

widelands-localedir.patch Edit (548 bytes, text/x-diff)

Revision history for this message

SirVer (sirver) wrote on 2010-04-30:

thanks pavol. jens, could you look into that?

Changed in widelands:
assignee:	nobody → Jens Beyer (Qcumber-some) (qcumber-some)

SirVer (sirver) on 2010-05-05

Changed in widelands:
milestone:	none → build16-rc1
status:	New → Confirmed
importance:	Undecided → Medium

Revision history for this message

Jens Beyer (qcumber-some) wrote on 2010-05-14:

Actually the patch won't help, as WL_INSTALL_LOCALEDIR must in fact be different from WLBUILD_INSTALL_LOCALEDIR.

WL_INSTALL_LOCALEDIR is the directory where the executable will find the locales once installed.
WLBUILD_INSTALL_LOCALEDIR is the directory where 'make install' does the installation. This is different for example on Gentoo Linux.

But I see/realize the problem arising from the code line in question. I'll have a deeper look into that.

Changed in widelands:
status:	Confirmed → In Progress

Revision history for this message

Jens Beyer (qcumber-some) wrote on 2010-10-31:

As this patch will not solve the whole problem, we will not include it in Build16.
However we see the problems and will address them in a different fashion.

Setting this patch request as Invalid.