Disallow empty game names in internet lobby

Bug #1833352 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Medium
Unassigned

Bug Description

It is possible to host a new game in the internet lobby without giving it a name.

When a player starts hosting and the name is empty, we should have a prompt with an input field so that the player can provide a name without hassle.

Related branches

Revision history for this message
Toni Förster (stonerl) wrote :

This shouldn't be possible anymore. I fixed this while working on the login box.

Revision history for this message
GunChleoc (gunchleoc) wrote :
Revision history for this message
Toni Förster (stonerl) wrote :

I need to test this later, but the game name isn't empty. It uses the translated string for no name. Just open a second client. And the new game should appear in the games list.

Revision history for this message
Toni Förster (stonerl) wrote :

Ahh. Now I know what I fixed :D. It was possible to have more than one game without a name on the metaserver. Which I think crashed the server, or client duno anymore? This was my fix. If a game with no name already exists the next empty game will be called unnamed1, unnamed2 and so on.

Revision history for this message
Toni Förster (stonerl) wrote :

Empty game names were a corner case, that only occurred when no games were opened.

GunChleoc (gunchleoc)
Changed in widelands:
status: New → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :
Changed in widelands:
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.