AI does not expand to unguarded enemy land

[hessenfarmer]

AI does not expand into unguarded but enemy owned land. this is due to only unowned spots are taken into account for this consideration.

relevant code is in defaultai.cc line 1329 following.

proposal is to change line 1329 like the following

if (field.unowned_land_nearby > 0 || (field.enemy_owned_land_nearby > 0 && field.enemy_military_presence < std::abs(management_data.get_military_number_at(??) / 6))) {

furthermore this would lead to the addition of the following block after line 1335

field.unowned_buildable_spots_nearby +=
     map.find_fields(Area<FCoords>(field.coords, kBuildableSpotsCheckArea),
                     &found_buildable_fields, find_enemy_owned_walkable);

already tested this solution and it works

[TiborB (tiborb95)]

what is that "??"

[hessenfarmer (stephan-lutz)]

?? is a placeholder for an unused military_number. Sorry should have explained that.

[TiborB (tiborb95)]

OK, I believed that you already has the code... Do you need some help with finding unused number? I am using grep for this...

Will you propose merging the branch? it would be easier to see changes...

[hessenfarmer (stephan-lutz)]

I tested the code with a hardcoded value of 3 (which means an enemy military presence of 3 is allowed), but I thought some genetics should apply here.

[GunChleoc (gunchleoc)]

Migrated to https://github.com/widelands/widelands/issues/3423