widelands

wl_map_object_info returns wrong helptext for frisians well

Bug #1818909 reported by kaputtnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned
widelands build20-rc1

Bug Description

Reported on the forum: https://wl.widelands.org/forum/post/27225/

I can reproduce this locally when updating the encyclodedia: The resulting json file contain already the wrong helptext.

Related branches

lp:~widelands-dev/widelands/bug-1818909-web-encyclopedia
hessenfarmer: Approve (code review)
Diff: 41 lines (+8/-2)
3 files modified
data/tribes/buildings/productionsites/frisians/well/helptexts.lua (+5/-0)
data/tribes/scripting/mapobject_info/ware_helptext.lua (+1/-1)
src/website/map_object_info.cc (+2/-1)
kaputtnik (franku)
summary: - map_object_info returns wron helptext for frisians well
+ wl_map_object_info returns wrong helptext for frisians well
Revision history for this message
Benedikt Straub (nordfriese) wrote :

And for wares, only the tribe-specific part of the description is returned. "General" parts of the text (that should be included for all tribes) are omitted, e.g. https://wl.widelands.org/encyclopedia/frisians/wares/gold_ore/

Revision history for this message
Benedikt Straub (nordfriese) wrote :

And the enhancement costs for upgraded buildings are also missing

Revision history for this message
kaputtnik (franku) wrote :

See also bug 336021 'the online-help should be enhanced', especially comment #21 ff.

GunChleoc (gunchleoc)
tags: added: documentation
GunChleoc (gunchleoc)
Changed in widelands:
milestone: none → build20-rc1
assignee: nobody → GunChleoc (gunchleoc)
Revision history for this message
GunChleoc (gunchleoc) wrote :

What happened here is that the Well was missing its purpose helptext, so Lua returned the previous purpose helptext. I have now added the purpose helptext to the well, and the problem goes away.

I have also added the missing info to the wares.

Any expansion of content should be done with the other bug - we should keep the fix small so that we can have it for Build 20.

GunChleoc (gunchleoc)
Changed in widelands:
status: New → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers