Add statistics hook for Territorial functions

Bug #1817550 reported by GunChleoc
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Medium
Unassigned

Bug Description

When https://code.launchpad.net/~widelands-dev/widelands/bug-1810062-territorial-calculations/+merge/361366 is merged, the map statistics won't match the win points any more.

Add a statistics hook to Territorial Time and Territorial Lord to reflect that.

Tags: wincondition

Related branches

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I managed to create a hook. After the merge of the calculations branch I will create a new branch for b21.

Shall we show the points or shall we show the percentage instead?

Revision history for this message
GunChleoc (gunchleoc) wrote :

I'd be OK with both options. Percentage might be easier to understand.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I would go for percentage as well, as it is clearly visible how far away from the target (50%) a player is.

I subscribed Toni as I'd like to hear his opinion on this.

Revision history for this message
Toni Förster (stonerl) wrote :

+1 for percentage.

For the same reason: easier for the user to see how far away he/she is from the target

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Ok I will start a branch tonight:
going for percentage using the image from collectors (small column diagram)
I will do the same for artifacts as well

Changed in widelands:
assignee: nobody → hessenfarmer (stephan-lutz)
Revision history for this message
Toni Förster (stonerl) wrote :

I made an icon for the artifacts stats.

Revision history for this message
Toni Förster (stonerl) wrote :

Here is an icon for Territorial.

Revision history for this message
Toni Förster (stonerl) wrote :

Here is another icon for Territorial. I prefer the big over the small but have a look yourself.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

branch is onli´ne so we can already start the review

Changed in widelands:
status: New → In Progress
Changed in widelands:
status: In Progress → Fix Committed
assignee: hessenfarmer (stephan-lutz) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :
Changed in widelands:
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.