scrolling not possible with arrow keys

[Toni Förster]

I'm runnig build 8937 on macOS 10.14.2. The bug is as follows:

As soon as I press one of the menu buttons, it is not possible to scroll using the arrow keys anymore. The only way the get scrolling working again, is to build a building or flag post. This happens on the Editor as well.

When using the keyboard shortcuts (m, space, o, F1, etc) instead of the buttons the bug does not appear.

[Benedikt Straub (nordfriese)]

I can confirm this. A non-critical but very very annoying bug that occurs quite frequently, perhaps we should target it for build 20…

It´s also possible to re-enable scrolling by opening and closing a window using the shortcut (e.g. press 'N' twice). Looks like the focus is not transferred correctly sometimes.

[Toni Förster (stonerl)]

Does not work for all shortcuts though.

Using these shortcuts it does enable scrolling again:

- n
- ENTER
- e

These shortcuts do not work:

- m
- i
- o
- b
- F1
- SPACE
- CTRL+0

... and I guess all the others also do not, but haven't tested.

[Toni Förster (stonerl)]

I tested the linked branch.

Now the arrow keys work. But when the following windows are open they don't.

- n (Message Window)
- e (Seafaring Stats)
- ENTER (Chat Window)

The windows need to be closed first. All other windows can be opened while using the arrow key.

[Toni Förster (stonerl)]

I meant "... can stay open..." not "...be opened..."

[Toni Förster (stonerl)]

I'm stupid :( These 3 Windows need focus for the lists...

[Notabilis (notabilis27)]

Thanks for testing! I now requested a merge, which I haven't done before since I still wanted to understand the behavior of the code.
Thanks also for testing the bug and mentioning the keys in #2, that helped a lot figuring this out. And you are right that the three windows are needing the keyboard focus. The other dialogs requested it as well, but didn't provided any action for the grabbed keys, leading to the annoying behavior.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1