update.sh deletes files when there is no new version

Bug #1806901 reported by GunChleoc on 2018-12-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Undecided
Unassigned

Bug Description

https://wl.widelands.org/forum/topic/4417/

Running update.sh twice in a row will delete the executables without providing any new ones.

Tested with bzr 8937.

Related branches

kaputtnik (franku) wrote :

I can't confirm this for a fresh branch.

But i think what is going on here: The update script will not be regenerated if you call it. If this script was made with a version prior r8907 (cp VERSION file), it will contain 'mv VERSION ..' and thus fails if running twice.

The solution is either to run compile.sh again, which regenerates update.sh, or replace 'mv VERSION ../VERSION' with 'cp VERSION ../VERSION' inside update.sh.

Maybe better is to call compile.sh from update.sh. This will run cmake again, so needs more time, but maybe it also better to configure the project again if some third party packages are updated?

IMHO using one compile logic is better than maintaining two parts.

GunChleoc (gunchleoc) wrote :

+1 for calling compile.sh again. We need to make sure to call it with the same parameters

kaputtnik (franku) on 2018-12-25
Changed in widelands:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers